Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check CI for 2.2 #299

Closed
wants to merge 1 commit into from
Closed

Check CI for 2.2 #299

wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

No description provided.

@phil-davis
Copy link
Contributor Author

PHP CS Fixer 3.64.0 wants to add a trailing comma to the parameters of the list() "function"

But the old PHP CS fixer v2 does not require that, and in fact it tries to refactor the code removing the trailing comma.
It is getting more difficult to keep supporting all the way from PHP 7.1 to 8.4 and with the different major versions of the code style and analysis tools.

@staabm
Copy link
Member

staabm commented Sep 5, 2024

IMO dropping 7.x (or everything below 7.4h should be considered )

@phil-davis
Copy link
Contributor Author

IMO dropping 7.x (or everything below 7.4h should be considered

Agree - I will set all the repos to a minimum of 7.4 supported. The analysis tools are all still supporting that OK, and 7.4 has a good range of the "new" code styling options available.

@phil-davis
Copy link
Contributor Author

I got it passing in #298 by pinning php-cs-fixer to 3.63.2 - that will do for now.

@phil-davis phil-davis closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants