Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CSS to center the button #477

Closed

Conversation

Acksout
Copy link

@Acksout Acksout commented Jul 23, 2024

Address issue #476

Title and Issue number

Title : JavaScript: Timer Quiz - Back button not working

Issue No. : #476

Code Stack : CSS

Close #476

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have created a helpful and easy to understand README.md
  • [] I have updated the Index.html file for my contribution

Address PR  #476

Signed-off-by: Rakshit Bhardwaj <157364563+Acksout@users.noreply.github.com>
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for frontend-mini-challenges ready!

Name Link
🔨 Latest commit f2cd5bf
🔍 Latest deploy log https://app.netlify.com/sites/frontend-mini-challenges/deploys/669ff160222358000871a680
😎 Deploy Preview https://deploy-preview-477--frontend-mini-challenges.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sadanandpai
Copy link
Owner

Back button is still not working

…nts.

Signed-off-by: Rakshit Bhardwaj <157364563+Acksout@users.noreply.github.com>
@Acksout
Copy link
Author

Acksout commented Jul 23, 2024

This should work. Did a manual check and the change doesn't seem to have broken anything else. @sadanandpai

@@ -7,6 +7,7 @@
background: linear-gradient(180deg, lavenderblush 0%, white 100%);
box-shadow: 0 4px 4px 0 rgba(0, 0, 0, 10%);
position: relative;
z-index: 2;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should not be an overlap between the layers. I don't think there is a need to increase the z-index here.

@sadanandpai
Copy link
Owner

We are good to display it in this way. We can get rid of unnecessary absolutes and z-indexes.

image

Copy link
Owner

@sadanandpai sadanandpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not touch navbar. Navbar is working fine overall. only if necessary lets modfiy it

@Acksout
Copy link
Author

Acksout commented Jul 24, 2024

Setting z-index: -1 only on .start-screen fixes the issue without modifying navbar. Should I go ahead with these changes?
.start-screen { position: absolute; top: 0; left: 0; right: 0; bottom: 0; display: flex; justify-content: center; align-items: center; z-index: -1; }

@sadanandpai
Copy link
Owner

Let me handle this. Thanks for your contribution. @Acksout

@sadanandpai
Copy link
Owner

Fixed

@Acksout Acksout deleted the fixing-quiz-app-with-timer-button branch July 27, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript: Timer Quiz - Back button not working
2 participants