-
Notifications
You must be signed in to change notification settings - Fork 926
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This pull request includes various minor corrections and improvements to the codebase, primarily focused on fixing typos and improving clarity in comments and documentation. The address will be regenerated for the CHANGELOG in a separate PR once this PR is merged. ### Documentation and Comment Improvements: * Corrected typos and improved clarity in comments across multiple files, including `contracts/Safe.sol`, `contracts/base/FallbackManager.sol`, `contracts/base/GuardManager.sol`, and more. [[1]](diffhunk://#diff-587b494ea631bb6b7adf4fc3e1a2e6a277a385ff16e1163b26e39de24e9483deL31-R31) [[2]](diffhunk://#diff-587b494ea631bb6b7adf4fc3e1a2e6a277a385ff16e1163b26e39de24e9483deL94-R101) [[3]](diffhunk://#diff-587b494ea631bb6b7adf4fc3e1a2e6a277a385ff16e1163b26e39de24e9483deL167-R167) [[4]](diffhunk://#diff-587b494ea631bb6b7adf4fc3e1a2e6a277a385ff16e1163b26e39de24e9483deL303-R304) [[5]](diffhunk://#diff-5b429d16265a4811c02f813788ee8a558995600c739f7eff184544767119b3ffL53-R61) [[6]](diffhunk://#diff-657b684b5cb5e637061eee5f7184f2f07d7077822192dc6e577d1ba786d7dd08L44-R44) [[7]](diffhunk://#diff-82762908b9416ddadffb149ee4d25f328078fc27f938d454d8a207aad1ec3839L72-R80) [[8]](diffhunk://#diff-82762908b9416ddadffb149ee4d25f328078fc27f938d454d8a207aad1ec3839L229-R229) [[9]](diffhunk://#diff-82762908b9416ddadffb149ee4d25f328078fc27f938d454d8a207aad1ec3839L241-R241) [[10]](diffhunk://#diff-795fb06764b4c2d991707584a31509badf0b036c9401bfbcb82d6bc9fdebab82L8-R8) [[11]](diffhunk://#diff-795fb06764b4c2d991707584a31509badf0b036c9401bfbcb82d6bc9fdebab82L30-R32) [[12]](diffhunk://#diff-7a34930a339acfe3b45e163bee3e08df2132c01826e6e03771827a4181c6f567L19-R19) [[13]](diffhunk://#diff-a7dd65d90b0567bb9ba14ecd4ff414529a934cd3752ccf309800fad93fba354eL12-R12) [[14]](diffhunk://#diff-45ea681fa13f307d8b998511744a26b824ed0366455c4c8c7b2fec17efbe6b35L26-R26) [[15]](diffhunk://#diff-2974a1e991d1528f345c77ee21a96dba70e82352e5924666dc2c5576b8ed9637L16-R16) [[16]](diffhunk://#diff-8f962f6dc833091675056d29e3ee1ad34c70d259a6c6e9371c732e78a7155359L42-R42) [[17]](diffhunk://#diff-8f962f6dc833091675056d29e3ee1ad34c70d259a6c6e9371c732e78a7155359L119-R119) [[18]](diffhunk://#diff-19a90186392862f1f41b151cfae86c5d34dffd78e4d358c58386b9240aa31a58L5-R5) [[19]](diffhunk://#diff-0b2d708a1eb2dc0c8b74b6e40007b2afc7df03bbc4a7f994a0833ddb277df384L10-R10) [[20]](diffhunk://#diff-62f21ce8850527f34ef2acdacd96d4a2a1150e3e2a7e16457e82236bbd4259d2L14-R14) [[21]](diffhunk://#diff-4763011ce3c09340f84758cd74f9f9fd7951e1aca207789847ca5c63e7d3ddc9L67-R67) [[22]](diffhunk://#diff-4763011ce3c09340f84758cd74f9f9fd7951e1aca207789847ca5c63e7d3ddc9L86-R86) [[23]](diffhunk://#diff-59325c0efc34794e4c2c873712d190bb642968404634af6fe8f5fb585811a41cL54-R54) [[24]](diffhunk://#diff-850f06cc1a3d3ce68df28ca73abce16a58e42ba86c15ce3667a3ecd8d7155441L89-R90) [[25]](diffhunk://#diff-35cf5e8e07a21f0128c32349d41c2d671c2c85866f384ac135f89164eb53922fL8-R8) ### Specific Changes: * [`contracts/Safe.sol`](diffhunk://#diff-587b494ea631bb6b7adf4fc3e1a2e6a277a385ff16e1163b26e39de24e9483deL31-R31): Corrected several typos in comments to improve readability and accuracy. [[1]](diffhunk://#diff-587b494ea631bb6b7adf4fc3e1a2e6a277a385ff16e1163b26e39de24e9483deL31-R31) [[2]](diffhunk://#diff-587b494ea631bb6b7adf4fc3e1a2e6a277a385ff16e1163b26e39de24e9483deL94-R101) [[3]](diffhunk://#diff-587b494ea631bb6b7adf4fc3e1a2e6a277a385ff16e1163b26e39de24e9483deL167-R167) [[4]](diffhunk://#diff-587b494ea631bb6b7adf4fc3e1a2e6a277a385ff16e1163b26e39de24e9483deL303-R304) * [`contracts/base/FallbackManager.sol`](diffhunk://#diff-5b429d16265a4811c02f813788ee8a558995600c739f7eff184544767119b3ffL53-R61): Fixed a typo in the comment regarding the use of `HandlerContext.sol`. * [`contracts/base/GuardManager.sol`](diffhunk://#diff-657b684b5cb5e637061eee5f7184f2f07d7077822192dc6e577d1ba786d7dd08L44-R44): Improved comment clarity by specifying "the transaction" instead of "transaction". * [`contracts/base/ModuleManager.sol`](diffhunk://#diff-82762908b9416ddadffb149ee4d25f328078fc27f938d454d8a207aad1ec3839L72-R80): Enhanced comments for better understanding of the setup and validation processes. [[1]](diffhunk://#diff-82762908b9416ddadffb149ee4d25f328078fc27f938d454d8a207aad1ec3839L72-R80) [[2]](diffhunk://#diff-82762908b9416ddadffb149ee4d25f328078fc27f938d454d8a207aad1ec3839L229-R229) [[3]](diffhunk://#diff-82762908b9416ddadffb149ee4d25f328078fc27f938d454d8a207aad1ec3839L241-R241) * [`contracts/base/OwnerManager.sol`](diffhunk://#diff-795fb06764b4c2d991707584a31509badf0b036c9401bfbcb82d6bc9fdebab82L8-R8): Clarified comments to ensure better comprehension of the setup function and validation checks. [[1]](diffhunk://#diff-795fb06764b4c2d991707584a31509badf0b036c9401bfbcb82d6bc9fdebab82L8-R8) [[2]](diffhunk://#diff-795fb06764b4c2d991707584a31509badf0b036c9401bfbcb82d6bc9fdebab82L30-R32) * [`contracts/common/SecuredTokenTransfer.sol`](diffhunk://#diff-7a34930a339acfe3b45e163bee3e08df2132c01826e6e03771827a4181c6f567L19-R19): Corrected the spelling of "keccak" in the comment. * [`contracts/common/StorageAccessible.sol`](diffhunk://#diff-a7dd65d90b0567bb9ba14ecd4ff414529a934cd3752ccf309800fad93fba354eL12-R12): Fixed a typo in the comment describing the storage reading function. * [`contracts/examples/guards/DelegateCallTransactionGuard.sol`](diffhunk://#diff-45ea681fa13f307d8b998511744a26b824ed0366455c4c8c7b2fec17efbe6b35L26-R26): Improved comment clarity regarding delegate call checks. * [`contracts/external/SafeMath.sol`](diffhunk://#diff-2974a1e991d1528f345c77ee21a96dba70e82352e5924666dc2c5576b8ed9637L16-R16): Enhanced comment for gas optimization explanation. * [`contracts/handler/CompatibilityFallbackHandler.sol`](diffhunk://#diff-8f962f6dc833091675056d29e3ee1ad34c70d259a6c6e9371c732e78a7155359L42-R42): Corrected and clarified comments related to message hashing and call return values. [[1]](diffhunk://#diff-8f962f6dc833091675056d29e3ee1ad34c70d259a6c6e9371c732e78a7155359L42-R42) [[2]](diffhunk://#diff-8f962f6dc833091675056d29e3ee1ad34c70d259a6c6e9371c732e78a7155359L119-R119) * [`contracts/handler/HandlerContext.sol`](diffhunk://#diff-19a90186392862f1f41b151cfae86c5d34dffd78e4d358c58386b9240aa31a58L5-R5): Fixed a typo in the context extraction comment. * [`contracts/handler/TokenCallbackHandler.sol`](diffhunk://#diff-0b2d708a1eb2dc0c8b74b6e40007b2afc7df03bbc4a7f994a0833ddb277df384L10-R10): Improved comment clarity on token callback handling. * [`contracts/handler/extensible/SignatureVerifierMuxer.sol`](diffhunk://#diff-62f21ce8850527f34ef2acdacd96d4a2a1150e3e2a7e16457e82236bbd4259d2L14-R14): Corrected a typo in the interface comment. * [`contracts/interfaces/IModuleManager.sol`](diffhunk://#diff-4763011ce3c09340f84758cd74f9f9fd7951e1aca207789847ca5c63e7d3ddc9L67-R67): Clarified comments regarding module enablement and guard setup. [[1]](diffhunk://#diff-4763011ce3c09340f84758cd74f9f9fd7951e1aca207789847ca5c63e7d3ddc9L67-R67) [[2]](diffhunk://#diff-4763011ce3c09340f84758cd74f9f9fd7951e1aca207789847ca5c63e7d3ddc9L86-R86) * [`contracts/interfaces/IOwnerManager.sol`](diffhunk://#diff-59325c0efc34794e4c2c873712d190bb642968404634af6fe8f5fb585811a41cL54-R54): Enhanced comment clarity on owner verification. * [`contracts/interfaces/ISafe.sol`](diffhunk://#diff-850f06cc1a3d3ce68df28ca73abce16a58e42ba86c15ce3667a3ecd8d7155441L89-R90): Improved comment clarity on signature verification. * [`contracts/libraries/ErrorMessage.sol`](diffhunk://#diff-35cf5e8e07a21f0128c32349d41c2d671c2c85866f384ac135f89164eb53922fL8-R8): Fixed a typo in the comment explaining the purpose of the contract.
- Loading branch information
Showing
29 changed files
with
51 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.