-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation on Windows #207
Conversation
5d7c03b
to
e8b72d9
Compare
@dimpase @fchapoton Tests are passing, so this is good to go from my side. Please have a careful look at the changes to make sure I'm not breaking anything on linux and macos here (I really don't have a strong understanding of signal processing on unix). |
you've removed |
It's now generated by meson: |
@@ -33,6 +33,19 @@ cimport cython | |||
import sys | |||
from gc import collect | |||
|
|||
# On Windows, some signals are not pre-defined. | |||
# We define them here with values that will never occur in practice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackoverflow.com/a/8420498/557937 shows how to do a sort of SIGALRM
on Windows
(outdated, - python 2.7 - so perhaps there are better ways now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for a future consideration - this PR doesn't need to do anything here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks Dima! |
Based on #206, we make cysignals compile nicely on Windows. The tests (that are meaningful for windows) are passing, but I'm not sure if further work is necessary to handle Windows specifics. In either case, this should serve as a good start.
Windows (mingw) is added to ci to make sure that it keeps working.
Fixes #201 and fixes #198