-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix latex rendering in sage-shell-view #71
Conversation
@EmmanuelCharpentier sounds good, thanks. |
HTH, |
This PR doesn't introduce any new variable, it actually deletes |
Wups ! I reverse-read your patch.... Deepest apologies ! |
No problem! |
Thanks a lot for this work ! Any show stopper merging this one ? Having to type "view(...)" each time and switching to my browser seriously disrupt my workflow. |
@EmmanuelCharpentier - I've promoted you to a maintainer of this repo, you can merge things now. |
@hivert - I can promote you to maintainer of this repo too - would you like to be one? |
First of all, thank for the proposition ! If I'd definitely like to help, I'm still at the script-kiddie level concerning emacs internals and lisp programming. I don't think I'm knowledgeable enough for the task. Sorry... |
@hivert - well, I suppose you can test things, and that's good enough. Of course I can merge this without looking (I haven't been using emacs for 20 years), but that's not as good. |
Thanks ! I'll do that (I've reviewed this patch already, and I'm using it currently). |
I just accepted the merge. It should appear on Melpa in a not too long time. Bug me if that doesn't happen. |
Well...
whereas my local branch does. I'll investigate. |
Could you please review this pull request which reintegrates @apresta 's fix, which somehow disappeared from the previous pull request I merged (after successfully reviewing its branch) ? Thanks again... |
This fixes issue #61.
Adapted from PR #70 with @aikrahguzar's help.