Fix build and tests with pari 2.17 #38749
Open
+368
−392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs work because this is not compatible with 2.15. So either it needs to be merged with the pari upgrade or be made to work with older pari too (no idea how). Running tests now. |
|
Many test failures. |
antonio-rojas
changed the title
2 tasks
antonio-rojas
force-pushed
the
pari-2.17
branch
from
a6acbfb to
f619b6f
Compare
|
If the changes here eventually allow us to use a system Pari 2.17, then we should undo the change in #38772. |
antonio-rojas
changed the title
|
With this MR and the cypari fixes sagemath/cypari2#165 and sagemath/cypari2#166 all tests are passing with pari 2.17. The changes are not compatible with 2.15 though, making them compatible requires more work. Also, some pari opeations (such as the number field prime ideals above a given prime) give random output with 2.17, which makes it harder to test. To solve both issues (and make tests more future proof), we should gradually move away from testing the exact output to just testing that the output is correct. |
antonio-rojas
force-pushed
the
pari-2.17
branch
from
257246c to
b3c57e1
Compare
tornaria
reviewed
Oct 30, 2024
tornaria
reviewed
Oct 30, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 7, 2024
We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 8, 2024
We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
|
More updates in antonio-rojas#4 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 9, 2024
We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 13, 2024
We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 14, 2024
We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
antonio-rojas
force-pushed
the
pari-2.17
branch
from
6d7c793 to
fbb32fd
Compare
NEXT_PRIME_VIADIFF is removed in 2.17, port pari_prime_range to pari_PRIMES instead
antonio-rojas
force-pushed
the
pari-2.17
branch
from
ee8ee5a to
29d8cc2
Compare
|
pari 2.17.1 is out with the needed fixes, so we should go ahead with the upgrade. We just need a cypari release including sagemath/cypari2#166 |
|
I think you missed one hunk in the last merge: --- a/src/sage/rings/integer.pyx
+++ b/src/sage/rings/integer.pyx
@@ -5585,7 +5585,7 @@ cdef class Integer(sage.structure.element.EuclideanDomainElement):
sage: 5.is_norm(K)
False
sage: n.is_norm(K, element=True)
- (True, 4*beta + 6)
+ (True, -4*beta + 6)
sage: n.is_norm(K, element=True)[1].norm()
4
sage: n = 5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEXT_PRIME_VIADIFFis removed in 2.17, portpari_prime_rangetopari_PRIMESinsteadNeeds sagemath/cypari2#165 applied to cypari