Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress mentions of ipython_genutils (7 years deprecated) #39077

Closed
wants to merge 1 commit into from

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Dec 4, 2024

This should not be a dependency of anything for the last ~7 years. If it is; it is a bug in the package.

I think that sage is one of the last pieces of software that mention it And might be the reason we still recieve request to remove nose as a testing framework to package it in opensuse ?


I don't have much clue what I'm doing, I grep-ed through all the files and removed any mentions, maybe some of those files need to be regenerated ?

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

This should not be a dependency of anything for the last ~7 years.
If it is; it is a bug in the package.

I think that sage is one of the last pieces of software that mention it
And might be the reason we still recieve request to remove nose as a
testing framework to package it in opensuse ?
@Carreau
Copy link
Contributor Author

Carreau commented Dec 4, 2024

(also sending to ee if something breaks, and what need to be patched)

Copy link

github-actions bot commented Dec 4, 2024

Documentation preview for this PR (built with commit 36835ca; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks a lot

@fchapoton
Copy link
Contributor

let's wait at least for the tests to finish

@fchapoton
Copy link
Contributor

It seems that we could use

./bootstrap-conda && tox -e update_conda_lock

but maybe it is enough to do this by hand.

@tobiasdiez please tell us if the merge request is ok like it is now

@tobiasdiez
Copy link
Contributor

The conda lock files don't need to be changed by hand, and in fact ipython_genutils will be installed in the env anyway because its pulled in as a dependency of some other package.

I cannot really speak about the changes in sage-the-distro but it appears to me that ipympl does still depends on ipython_genutils (only removed in matplotlib/ipympl@564cf6d, which is not yet released).

@Carreau
Copy link
Contributor Author

Carreau commented Dec 5, 2024

Yeah, I just realized it is needed by spyder as well as it vendors an old dependency.
It's annoying but it will take a few more month to be removable.

@Carreau
Copy link
Contributor Author

Carreau commented Dec 5, 2024

(closing for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants