Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erroneous member declaration in farey_symbol #39092

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

As you can see in the C++ header file, there is in fact no members named a, b, c, d. In fact it's an error in C++ to have a member function and member variable with the same name.

Newer versions of Cython gives hard-to-debug errors for this.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729
Copy link
Contributor Author

user202729 commented Dec 9, 2024

2024-12-09T01:45:53.8299280Z   sage/libs/braiding.cpp: In function 'PyObject* __pyx_pf_4sage_4libs_8braiding_30cyclic_slidings(PyObject*, PyObject*)':
2024-12-09T01:45:53.8300433Z   sage/libs/braiding.cpp:8947:27: error: 'CyclicSlidings' is not a member of 'Braiding'
2024-12-09T01:45:53.8301384Z    8947 |   __pyx_v_rop = Braiding::CyclicSlidings(__pyx_t_5, __PYX_STD_MOVE_IF_SUPPORTED(__pyx_t_6));
2024-12-09T01:45:53.8302090Z         |                           ^~~~~~~~~~~~~~

Weird but… looks unrelated to the change…? I guess I'll just wait for these (unrelated) issues to be fixed in master.


Repush to re-trigger GitHub actions.

Copy link

github-actions bot commented Dec 9, 2024

Documentation preview for this PR (built with commit 87d6b01; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant