unify and simplify orientation methods #39124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 86342f3; changes) is ready! 🎉 |
tscrim
approved these changes
Jan 20, 2025
|
Thanks! |
|
Thanks for the review |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 23, 2025
Fixes sagemath#38758. This PR follows sagemath#38758, sagemath#38757, sagemath#38778, sagemath#38809. it adds a helper method that initialize a directed copy of a graph with the same set of vertices. It copies all attributes. It helps simplifying the code of several orientation methods and avoids code duplication. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39124 Reported by: David Coudert Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 25, 2025
Fixes sagemath#38758. This PR follows sagemath#38758, sagemath#38757, sagemath#38778, sagemath#38809. it adds a helper method that initialize a directed copy of a graph with the same set of vertices. It copies all attributes. It helps simplifying the code of several orientation methods and avoids code duplication. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39124 Reported by: David Coudert Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38758.
This PR follows #38758, #38757, #38778, #38809. it adds a helper method that initialize a directed copy of a graph with the same set of vertices. It copies all attributes. It helps simplifying the code of several orientation methods and avoids code duplication.
📝 Checklist
⌛ Dependencies