Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update conda to use Python 3.12, drop 3.9 and 3.10 #39164

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update conda to use Python 3.12, drop 3.9 and 3.10 #39164

wants to merge 2 commits into from

Conversation

tobiasdiez
Copy link
Contributor

In line with Spec 0, we drop Python 3.9 and 3.10 support (in this PR only for conda). Instead Python 3.11 and 3.12 is used for the CI.

(Python 3.13 still needs a few package updates in the conda universe #39163)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 29a4862; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez tobiasdiez marked this pull request as ready for review December 19, 2024 05:35
@tobiasdiez tobiasdiez requested a review from dimpase December 23, 2024 04:39
@tobiasdiez
Copy link
Contributor Author

@dimpase could you please have a look? (It's already tested by ci and automatically generated, so no need to run it locally I think)

@dimpase
Copy link
Member

dimpase commented Jan 3, 2025

Please drop the CI for 3.9, too - I still see

Conda (ubuntu-latest, 3.9, environment) Expected — Waiting for status to be reported

@tobiasdiez
Copy link
Contributor Author

Please drop the CI for 3.9, too - I still see

Conda (ubuntu-latest, 3.9, environment) Expected — Waiting for status to be reported

It's already dropped. The message is saying that it expects an status report but haven't received one. This can be fixed, once this PR is merged, by changing the branch protection rules (need to be done by an admin under https://github.com/sagemath/sage/settings/branches)

@tobiasdiez tobiasdiez mentioned this pull request Jan 3, 2025
Open
5 tasks
dimpase
dimpase approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tobiasdiez
Copy link
Contributor Author

lgtm

Thanks!

@tobiasdiez tobiasdiez mentioned this pull request Jan 4, 2025
Draft
5 tasks
@vbraun
Copy link
Member

vbraun commented Jan 5, 2025 

$ ./bootstrap -s
[...]
Creating upstream/configure-3b2a01bf8013641a814112ff2f13b6b2c11cdd4d.tar.gz...
find: warning: you have specified the global option -maxdepth after the argument -name, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments.
tar: environment-3.[89]-*.yml: Cannot stat: No such file or directory
tar: Exiting with failure status due to previous errors

@dimpase dimpase force-pushed the conda-python-upgrade branch from 9ea715f to 854dbbd Compare January 6, 2025 04:13
@dimpase
Copy link
Member

dimpase commented Jan 6, 2025

trivial fix. Also took the opportunity to correct the order or find args

@tobiasdiez
Copy link
Contributor Author

trivial fix. Also took the opportunity to correct the order or find args

Thanks! Maybe, at some point, I'll remember to edit bootstrap - maybe.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 7, 2025
sagemathgh-39164: Update conda to use Python 3.12, drop 3.9 and 3.10
7d92748 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

In line with Spec 0, we drop Python 3.9 and 3.10 support (in this PR
only for conda). Instead Python 3.11 and 3.12 is used for the CI.

(Python 3.13 still needs a few package updates in the conda universe
sagemath#39163)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39164
Reported by: Tobias Diez
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 9, 2025
sagemathgh-39164: Update conda to use Python 3.12, drop 3.9 and 3.10
96b97fa 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

In line with Spec 0, we drop Python 3.9 and 3.10 support (in this PR
only for conda). Instead Python 3.11 and 3.12 is used for the CI.

(Python 3.13 still needs a few package updates in the conda universe
sagemath#39163)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39164
Reported by: Tobias Diez
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 10, 2025
sagemathgh-39164: Update conda to use Python 3.12, drop 3.9 and 3.10
2b38e2b 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

In line with Spec 0, we drop Python 3.9 and 3.10 support (in this PR
only for conda). Instead Python 3.11 and 3.12 is used for the CI.

(Python 3.13 still needs a few package updates in the conda universe
sagemath#39163)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39164
Reported by: Tobias Diez
Reviewer(s): Dima Pasechnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
c: build: configure c: distribution s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasdiez @dimpase @vbraun