Fix CremonaDatabase constructor #39179
Conversation
|
Documentation preview for this PR (built with commit 011e07f; changes) is ready! 🎉 |
src/sage/databases/cremona.py
Outdated
| sage: C = CremonaDatabase(mini=False) # optional - !database_cremona_ellcurve | ||
| Traceback (most recent call last): | ||
| ... | ||
| ValueError: full Cremona database is not available; run "sage -i database_cremona_ellcurve" to install it |
There was a problem hiding this comment.
Technically sage -i doesn't work with meson https://doc-release--sagemath.netlify.app/html/en/installation/meson
There was a problem hiding this comment.
Isn't this the standard way to install optional packages?
There was a problem hiding this comment.
If not, what is the standard way?
There was a problem hiding this comment.
I don't know either (as in I know it works with the monolithic build system but I heard it supposedly doesn't work with the case it's built from meson)? Maybe ask @tobiasdiez
There was a problem hiding this comment.
Perhaps we should regard meson build as an alternative experimental build system...
There was a problem hiding this comment.
Yes, sage -i doesn't work with neither conda nor meson, and also not on some other systems. So it would indeed be nice to phrase this warning in a way to make sense across all of these supported ways to install sage. Perhaps just link to https://doc.sagemath.org/html/en/reference/spkg/database_cremona_ellcurve.html
There was a problem hiding this comment.
Perhaps just link to https://doc.sagemath.org/html/en/reference/spkg/database_cremona_ellcurve.html
But that is even less descriptive. It explains neither conda install nor sage -i, and users may not know how to install optional package in the first place.
Can we just somehow make sage -i redirect to conda install?
There was a problem hiding this comment.
It explains neither
conda installnorsage -i
The first is because there is no package to install the cremona db via conda. The latter is indeed a "bug".
Can we just somehow make
sage -iredirect toconda install?
On arch, you would need to install https://aur.archlinux.org/packages/sage-data-cremona_ellcurve... (also missing btw from the docs page). I think such an automatic install would open a can of worms.
There was a problem hiding this comment.
I rephrased the message as @culler wished.
Fixes #39072
Alternative to #39116.
📝 Checklist
⌛ Dependencies