Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweaks in Ore polynomials #39232

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

fchapoton
Copy link
Contributor

a few minor changes in Ore polynomials

  • sort imports
  • better categories
  • no custom "is_commutative"

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 38441b3; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

The method "is_commutative" will be provided by the category. The doctests (moved to the top) are there to check that.

@dcoudert
Copy link
Contributor

dcoudert commented Jan 2, 2025

Thanks for the explanation.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 32ac5a3 into sagemath:develop Jan 4, 2025
22 of 25 checks passed
@fchapoton fchapoton deleted the tweaks_ore branch January 4, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants