Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor details in modular symbols / boundary #39236

Merged
merged 1 commit into from
Jan 4, 2025
Merged

minor details in modular symbols / boundary #39236

merged 1 commit into from
Jan 4, 2025

Conversation

fchapoton
Copy link
Contributor

mainly to remove the allusion there to the auld class ring.Ring

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

Documentation preview for this PR (built with commit b844e8f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dcoudert
dcoudert approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

merci David, et bonne année

@dcoudert
Copy link
Contributor

dcoudert commented Jan 2, 2025

Bonne année à toi aussi.

@vbraun vbraun merged commit c3fc140 into sagemath:develop Jan 4, 2025
19 of 24 checks passed
@fchapoton fchapoton deleted the minor_points_in_modular_symbol branch January 4, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: modular forms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @dcoudert @vbraun