fix(services/folder): improve folder name extraction for IMAP listing #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced the `list_folders` function in `sage_imap/services/folder.py` to better handle folder name extraction when listing IMAP folders. The previous implementation had potential issues with folder names that did not conform to the expected format. The new implementation uses a regular expression to extract the folder name more reliably. Additionally, fallback logic has been added to handle cases where the folder name format is unexpected. Closes sageteamorg#46.
ARYAN-NIKNEZHAD
suggested changes
Aug 22, 2024
- Remove legacy config files (.flake8, .pylintrc, mypy.ini, setup files) - Update .gitignore, .pre-commit-config.yaml, .readthedocs.yaml - Add CODE_OF_CONDUCT.md and tox.ini - Modify dependency files (poetry.lock, pyproject.toml) - Update sage_imap and stubs for compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced the
list_foldersfunction insage_imap/services/folder.pyto better handle folder name extraction when listing IMAP folders. The previous implementation had potential issues with folder names that did not conform to the expected format. The new implementation uses a regular expression to extract the folder name more reliably. Additionally, fallback logic has been added to handle cases where the folder name format is unexpected.Closes #46.