patch code review

CHANGELOG.md

@@ -1,5 +1,7 @@
-### 1.4.1 (WIP)
+### 1.4.1
+* Compatibility: Sidebar Expander
 * Bugfix: Put back players panel if switching hotbar position other than to extreme left without need to refresh
+* Bugfix: Removed unnecessary deprecated code
 
 ### 1.4.0
 * Enhancement: Achieve a new level of minimalism with new Minimal UI defaults and settings

module.json

@@ -3,7 +3,7 @@
 	"title": "Minimal UI",
 	"author": "JeansenVaars#2857",
 	"description": "Minimal UI allows customizing Foundry interface, by hiding, collapsing or resizing specific parts.",
-	"version": "1.4.0",
+	"version": "1.4.1",
 	"minimumCoreVersion": "9.233",
 	"compatibleCoreVersion": "9.238",
 	"dependencies": [
@@ -30,5 +30,5 @@
 	],
 	"url": "https://github.com/saif-ellafi/foundryvtt-minimal-ui.git",
 	"manifest": "https://github.com/saif-ellafi/foundryvtt-minimal-ui/releases/latest/download/module.json",
-	"download": "https://github.com/saif-ellafi/foundryvtt-minimal-ui/releases/download/1.4.0/foundryvtt-minimal-ui_1.4.0.zip"
+	"download": "https://github.com/saif-ellafi/foundryvtt-minimal-ui/releases/download/1.4.1/foundryvtt-minimal-ui_1.4.1.zip"
 }

modules/component/hotbar.js

@@ -23,11 +23,9 @@ export default class MinimalUIHotbar {
         </a>
         `
 
-    static async collapseHotbar() {
-        await ui.hotbar.collapse();
-    }
-
     static lockHotbar(unlock) {
+        if ((game.modules.get("custom-hotbar")?.active) || (game.modules.get('monks-hotbar-expansion')?.active))
+            return;
         const barLock = $("#bar-lock > i");
         if (MinimalUIHotbar.hotbarLocked && unlock) {
             rootStyle.setProperty('--hotbarypos', MinimalUIHotbar.cssHotbarHidden);
@@ -83,7 +81,7 @@ export default class MinimalUIHotbar {
     static configureHotbar() {
         switch (game.settings.get('minimal-ui', 'hotbar')) {
             case 'collapsed': {
-                MinimalUIHotbar.collapseHotbar();
+                ui.hotbar.collapse();
                 break;
             }
             case 'autohide': {

modules/patch.js

@@ -13,14 +13,9 @@ export default class MinimalUIPatch {
                 target.bringToTop();
         });
 
-        Hooks.once('ready', async function () {
-            $("#sidebar-tabs > a:nth-child(n)").click(function (eve) {
-                if (eve.currentTarget.classList.contains('collapse')) return;
-                const tabName = jQuery(eve.currentTarget).attr('data-tab');
-                if (ui.sidebar._collapsed) {
-                    ui.sidebar.activateTab(tabName);
-                }
-            });
+        Hooks.on('renderSidebarTab', function (app) {
+            if (ui.sidebar._collapsed && app)
+                app.bringToTop();
         });
     }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "foundryvtt-minimal-ui",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Minimal UI allows customizing Foundry interface, by hiding, collapsing or resizing specific parts.",
   "main": "minimalui.js",
   "scripts": {