Fix sequential loading with multiple environments #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae6a2d7.
This reverts commit 9de2c16.
* Clang-format now passes * cpplint now passes * Install only the requirements needed for Sokoban even when testing * Satisfy the linters * Ran `make format` * Ability to run python tests * Devtools added * Run every linter and test * Fix schema * Run on CircleCI * Fix lint complaint about top-level std::string const.
- Update to image with Pytorch 2.2.1 - LLVM changed version 10->14, so make `clang-format` and `clang-tidy` new versions happy.
- Check deadlock condition for when the box is stuck in a corner that's not a goal - Add a script `astar_log_level.cc` to solve a particular level in a file. This should be used when logging levels across a small number of files. - `astar_log.cc` should still be used to log levels across a large number of files.
I implemented and added tests for: - the environment returns `truncate=True` (rather than `terminate=True`) when the time limit is exceeded - when the environment gets solved at the very last step when it would be truncated, it's returned as `terminated` I also fixed a previous bug: - Python tests failing would not make CI fail. `pytest.main` is not enough, one needs to explicitly check its return value and exit with it.
Co-authored-by: Adrià Garriga-Alonso <adria@far.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.