-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 5 new strips, fix one old one #108
base: devel
Are you sure you want to change the base?
Add 5 new strips, fix one old one #108
Conversation
And only after submitting this I realized that thefarside does properly retrieve the images, but they do not include the captions, so most of them are rather incomprehensible 😿 |
Thank you very much! Now I feel a bit obliged to create a new release, soon (which is not a bad thing, see below). I hope I can spare the time the next weekend. WRT "The Far Side": I am a fan of it since being on school exchange in Washington state in the late 1980ies. Updating DailyComic's metadata for it a few years ago let me finally understand why my "exchange mother" was such a big fan (and infected me): Gary Larson is from Seattle. I will try to quickly review the rest of this PR in the next days. P.S.: Your contributions mean a big uplift for my motivation to maintain DailyComics. Because the original creator did stall all PR for years (without deciding to merge them or not), I closed all my PRs on 2023-09-23 and forked DailyComics (in the original sense of "to fork", i.e. "to continue this project separately"), after unsuccessfully proposing to collaborate a few times. P.P.S.: You can use GitHub's search (input field in top left of its web-frontend page) to avoid redoing things which were tried before. E.g. searching for "foo" in this repository results in this search link: |
Yes, I concur that The Far Side like this doesn't really work and including it like this doesn't make sense. One future enhancement might be to be able to display text alongside the image — that would also be the place to include the xkcd rollover texts. I will admit I still don't quite understand what use the program makes of the specified color, I cannot recall having seen any comics or cover images on my phone on anything but a black background? The colors I've specified with these patches were mostly taken from the cover image, assuming this somehow is representative of color scheme. Edit: for example, what should it be for black-and-white comics? |
Deleted by commit
If you want to avoid this to become forgotten, please file a feature request as a new issue suggesting exactly this (maybe a little bit more fleshed out).
When I reworked the
Correct, this is another (but rather soft) requirement stated in
Pick a different, but similar background colour. 😉 E.g. "almost white" (e.g. |
My four review comments as screenshots, because something is apparently not working with GitHub's "review"-functionality, lately. As already stated, only the first two contain real questions, the other two are just comments (feel free to comment them, too). |
Added five new strips (with hopefully accurate information and suitable cover + sample images):
thefarside (Larson's website thefarside.com)And corrected retrieval of kamalaluonto (now from Keskisuomalainen newspaper), and updated also its information.
Closes issue #103.