Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develmaster: First round of commits for v1.9.95-beta1 #27

Merged
merged 43 commits into from
Oct 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
1fa83f0
[.gitignore] Extend sigificantly …
Olf0 Sep 28, 2023
fee7d2f
[harbour-dailycomics.desktop] Trivially bail out of SailJail
Olf0 Sep 28, 2023
f0222b2
Create `translations/README.md`
Olf0 Sep 28, 2023
b64b5eb
[LICENSE.txt] Remove duplicated entries, add ichthyosaurus' name
Olf0 Sep 28, 2023
ddbbf81
[FavoritesPage.qml] Remove push up menu and "problem email"
Olf0 Sep 28, 2023
f33a91f
Create `.transifex/config.yml`
Olf0 Sep 28, 2023
5ff1eb4
[harbour-dailycomics-de.ts] `de_DE` → `de`
Olf0 Sep 28, 2023
f2e5ca1
Delete `translations/harbour-dailycomics-en.ts`
Olf0 Sep 28, 2023
2a3599a
[harbour-dailycomics-fr.ts] `fr_FR` → `fr`
Olf0 Sep 28, 2023
b29bd48
[harbour-dailycomics-sv.ts] `sv_SV` → `sv`
Olf0 Sep 28, 2023
a177c6e
[harbour-dailycomics.ts] Add `language="en"`
Olf0 Sep 28, 2023
ee75b30
[harbour-dailycomics.spec] Tidy up
Olf0 Sep 28, 2023
f26dda8
Delete `rpm/harbour-dailycomics.yaml`
Olf0 Sep 28, 2023
d395f84
Create harbour-dailycomics.rpmlintrc
Olf0 Sep 28, 2023
3625299
Translation files: Clean up a bit (#17)
Olf0 Sep 28, 2023
08c3844
[harbour-dailycomics.spec] Further clean-ups an commenting the incomp…
Olf0 Sep 28, 2023
289a099
[translations/harbour-dailycomics.ts] Rectify `en` source file
Olf0 Sep 28, 2023
94ead73
[harbour-dailycomics.spec] Enhance and comment a lot
Olf0 Sep 29, 2023
339e809
[harbour-dailycomics.ts] Adapt to commit ddbbf81
Olf0 Sep 29, 2023
8cca8a3
Translate harbour-dailycomics.ts in de
transifex-integration[bot] Sep 29, 2023
df95930
Merge pull request #19 from sailfishos-applications/translations_84d7…
Olf0 Sep 29, 2023
fc29c59
Add `.github` directory from FileCase
Olf0 Sep 30, 2023
eb9d034
[AboutPage.qml] Update copyright holders
Olf0 Sep 30, 2023
a8c9823
[FavoritesPage.qml] Update copyright holders
Olf0 Sep 30, 2023
405ff26
Update copyright holders (#21)
Olf0 Sep 30, 2023
2a79ef5
Rework issue templates (#20)
Olf0 Sep 30, 2023
345ec9d
[AboutPage.qml] Use regular HTML- and XHTML-compatible syntax and quo…
Olf0 Oct 1, 2023
6264c3a
[harbour-dailycomics.ts] Adapt to commit 345ec9d
Olf0 Oct 1, 2023
d685022
Use regular HTML(v4 and v5)- and XHTML-compatible syntax and quoting …
Olf0 Oct 1, 2023
fae3d2a
[ComicItem.qml] Update copyright information
Olf0 Oct 1, 2023
5d8d87c
LICENSE.txt] Update copyright information
Olf0 Oct 1, 2023
75b6e00
[Constants.qml] Update GitHub repo URL
Olf0 Oct 1, 2023
4dbc850
Adapt to altered name of license file
Olf0 Oct 1, 2023
6b1976b
Add email addresses to copyright holders
Olf0 Oct 1, 2023
96286b7
[AboutPage.qml] Use regular email addresses of Damien & Oleg
Olf0 Oct 1, 2023
0762c5d
[FavoritesPage.qml] Use regular email addresses of Damien & Oleg
Olf0 Oct 1, 2023
e8c682b
Use regular email addresses of Damien & Oleg in copyright info (#25)
Olf0 Oct 1, 2023
bb898fa
[LICENSE.txt] Add references to MIT license at SPDX.org and OSI (open…
Olf0 Oct 1, 2023
42f8209
[LICENSE.txt] Use regular email addresses of Damien & Oleg
Olf0 Oct 1, 2023
c9ac75c
[LICENSE.txt] Unify quoting of commit names of persons
Olf0 Oct 1, 2023
8b68199
[harbour-dailycomics.spec] Add metadata for SailfishOS:Chum community…
Olf0 Oct 1, 2023
6e2a72e
Overhaul RPM related files (#18)
Olf0 Oct 1, 2023
4520c80
Translate harbour-dailycomics.ts in de (#26)
transifex-integration[bot] Oct 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/1_fix-strip.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: Fix strip
about: Extracting a comic strip for Daily Comics is broken
title: "[Fix strip] "
labels: 'fix strip'
---

**Daily Comics VERSION** (Daily Comics → [Top pulley] About): ***`<x.y.z>`***
<br />

#### REQUIRED DATA
- Name of the strip<br />
***\<name in Daily Comics\>***
- Document, whose source code allows for extracting a URL to a single image of the newest, published strip by a RegEx (see next bullet point). This page may be identical to the home-page of the strip.<br />
***\<URL\>***
- An idea for a RegEx (regular expression) to do so, containing a sub-expression which exactly matches the image URL<br />
***`<RegEx>`***
- If such a single RegEx is not feasible, please design a JavaScript code snippet, which extracts the URL to the image of the current comic strip from the document retrieved via the URL provided in the first bullet point of this section "NECESSARY DATA".
```
<JavaScript code>
```

#### ADDITIONAL INFORMATION
*\<Please consider thoroughly which other pieces of information may be relevant.\>*

41 changes: 41 additions & 0 deletions .github/ISSUE_TEMPLATE/2_new-strip.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
---
name: New strip
about: Suggest a new comic strip for Daily Comics
title: "[New strip] "
labels: 'new strip'
---

**Daily Comics VERSION** (Daily Comics → [Top pulley] About): ***`<x.y.z>`***
<br />

#### REQUIRED DATA
- Name of the strip<br />
***\<official, full name\>***
- Author(s)<br />
***\<real name(s), if available, and pseudonym(s) / nickname(s)\>***
- Home webpage<br />
***\<URL to official webpage\>***
- Existing strip, which is very typical for this comic strip; *should* include the main character(s) and / or scenery of this strip<br />
***\<URL or image file\>***
- Easily recognisable logo, icon or picture for the cover page of this
strip; *might* include either a scetch of the author(s), or the main character(s) and / or scenery of this strip<br />
***\<URL or image file\>***

See **[this document] ()** for details on these requirements, the image resolutions stated there are the minimal ones: Images can be easily downscaled, but up-scaling always involves a significant loss of visual quality.

#### NECESSARY DATA
These are technically necessary to implement a new strip source in Daily Comics.
- Document, whose source code allows for extracting a URL to a single image of the newest, published strip by a RegEx (see next bullet point). This page can be identical to the home-page of the strip, which must be provided in the prior section "REQUIRED DATA".<br />
***\<URL\>***
- An idea for a RegEx (regular expression) to do so, containing a sub-expression which exactly matches the image URL<br />
***`<RegEx>`***
- If such a single RegEx is not feasible, please design a JavaScript code snippet, which extracts the URL to the image of the current comic strip from the document retrieved via the URL provided in the first bullet point of this section "NECESSARY DATA".
```
<JavaScript code>
```

Also providing this necessary data lowers the time and effort it takes to implement a new strip significantly. Or provide a pull request (PR) for this new comic strip, after having read **[this guidance] ()**.

#### ADDITIONAL INFORMATION
*\<Please consider thoroughly which other pieces of information may be relevant.\>*

23 changes: 23 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: Bug report
about: Report a bug for this project
title: "[Bug] "
labels: 'bug'
---

**SailfishOS VERSION** (Settings → About product → Build): ***`<a.b.c.p>`***
<br />**HARDWARE** (Settings → About product → Manufacturer & Product name): ***\<Manufacturer\>, \<Product name\>***
<br />**Daily Comics VERSION** (Daily Comics → [Top pulley] About): ***`<x.y.z>`***
<br />

#### BUG DESCRIPTION
*\<A comprehensive description of this bug. Please do report only a single bug in each bug report!\>*

#### STEPS TO REPRODUCE
1. *\<foo\>*
2. *\<bar\>*
3. *\<foobar\>*

#### ADDITIONAL INFORMATION
*\<Please consider which other pieces of information may be relevant: Denote if this is not always reproducible, if this is a regression (then name to which older version), attach relevant data such as log files or the systemd journal, provide screenshots etc.\>*

23 changes: 23 additions & 0 deletions .github/ISSUE_TEMPLATE/help-form.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: Help form
about: Questions about this project
title: "[Help] "
labels: 'question'
---

**SailfishOS VERSION** (Settings → About product → Build): ***`<a.b.c.p>`***
<br />**HARDWARE** (Settings → About product → Manufacturer & Product name): ***\<Manufacturer\>, \<Product name\>***
<br />**Daily Comics VERSION** (Daily Comics → [Top pulley] About): ***`<x.y.z>`***
<br />

#### QUESTION
*\<A concisely phrased question. Please do ask only a single question in each help request!\>*

#### STEPS TO REPRODUCE
1. *\<foo\>*
2. *\<bar\>*
3. *\<foobar\>*

#### ADDITIONAL INFORMATION
*\<Please consider which other pieces of information may be relevant: Attach relevant data, provide screenshots etc.\>*

13 changes: 13 additions & 0 deletions .github/ISSUE_TEMPLATE/suggestion.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
name: Feature request
about: Suggest an idea for this project
title: "[Suggestion] "
labels: 'feature request'
---

#### DESCRIPTION
*\<A concisely phrased suggestion. Please do pose only a single suggestion in each feature request!\>*

#### ADDITIONAL INFORMATION
*\<Please consider which other pieces of information may be relevant: Attach relevant data, provide screenshots etc.\>*

62 changes: 62 additions & 0 deletions .github/workflows/build-on-pull_req.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
name: CI on PRs with SDK for 2.2.0 (i486)

env:
RELEASE: 2.2.0.29
ARCH: i486
# Do not wait up to the default of 10 minutes for network timeouts in a workflow which runs ca. 3 minutes.
SEGMENT_DOWNLOAD_TIMEOUT_MINS: 1

on:
pull_request:
branches:
- devel
- master
# Allows to run this workflow manually from the Actions tab.
workflow_dispatch:

defaults:
run:
# Note that 'bash' provides -o pipefail, in contrast to the default (i.e., unspecified, which also uses bash) or 'sh',
# see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
shell: sh

# Do not use concurrency in order to enforce checking every commit of a Pull Request.
# See, e.g.: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow
#concurrency:
#group: ci-${{ github.ref_name }}
# 'false' (default) allows for two concurrent runs, one executing and one freshly enqueued; 'true' for only one; no 'concurrency:' defined for multiple.
#cancel-in-progress: false

jobs:
build:
runs-on: ubuntu-22.04
steps:

- name: Checkout
uses: actions/checkout@v3

# Caching Docker images is not ready yet, see
# https://github.com/storeman-developers/harbour-storeman-installer/blob/devel/cache-docker-images_github-ci.md
#- name: Cache Docker images of the Sailfish-SDK
# id: cache-sdk
# uses: actions/cache@v3
# with:
# path: $GITHUB_WORKSPACE/…
# key: cache

- name: Prepare
run: mkdir RPMS

- name: Build ${{ env.ARCH }}
uses: coderus/github-sfos-build@old-stable
with:
# Solely builds for i486 on 2.2.0, because of https://github.com/sailfishos-patches/patchmanager/pull/437#issuecomment-1615317003
release: ${{ env.RELEASE }}
arch: ${{ env.ARCH }}

- name: Upload build result
uses: actions/upload-artifact@v3
with:
name: RPM-build-results_${{ github.base_ref }}-${{ env.ARCH }}-SFOS2.2.0+
path: RPMS/

Loading