Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete plugins/donaldduck, because … #38

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Delete plugins/donaldduck, because … #38

merged 1 commit into from
Mar 24, 2024

Conversation

Olf0
Copy link

@Olf0 Olf0 commented Oct 16, 2023

… it only extracts the first picture of 5 strips, which rotate daily since March 2022.

Fixes issue #30.

… it only extracts the first picture of 5 strips, which rotate daily since March 2022.
@Olf0 Olf0 self-assigned this Oct 16, 2023
Copy link
Author

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Olf0 Olf0 merged commit 8768b48 into devel Mar 24, 2024
1 check passed
@Olf0 Olf0 deleted the remove-donaldduck branch March 24, 2024 20:23
Olf0 added a commit that referenced this pull request Mar 25, 2024
* [pre-commit] Fix RegEx and optimise a bit

* [pre-commit] Fix quoting

* Delete `plugins/donaldduck`, because … (#38)
  … it only extracts the first picture of 5 strips, which rotate daily since March 2022.  Fixes issue #30.

* Fix/settings page (#39)

* fix: Settings page to use renamed component ReportNewComicRectangle introduced in 8eb2ba3

* fix: corrected spelling mistake

* [AboutPage.qml] Fix spelling of "Hauke"

* [FavoritesPage.qml] Fix spelling of "Hauke"

* [LICENSE.txt] Fix spelling of "Hauke"

* [LICENSE.txt] Fix spelling of "Hauke" at a different location

* [ComicsSettingsPage.qml] Add copyright notice

---------

Co-authored-by: olf <Olf0@users.noreply.github.com>

* update german translation texts (#40)

* update german translation texts

* [LICENSE.txt] Add year due to this PR #40

* [README.md] Add year due to this PR #40

---------

Co-authored-by: olf <Olf0@users.noreply.github.com>

* Re-add 256x256 icon removed by commit 99c1fdd (#41)

* Create directory `256x256`

* Add file via upload

* Technically refresh logo SVG and PNGs

* [README.md] Enhance slighty, in sync with FlowPlayer etc.

* [build-on-tags.yml] Update to FlowPlayer's state

* [build-on-pull_req.yml] Update to FlowPlayer's state

* Update harbour-dailycomics.spec

* [README.md] Add 2024 as year of my code contributions

* [README.md] Add 2024 as year of cnlpete's code contribution

---------

Co-authored-by: Hauke Schade <github@cnlpete.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant