Skip to content

Commit

Permalink
fix(route53-targets): deprecated method for dns name is used in userp…
Browse files Browse the repository at this point in the history
…ool domain target (under feature flag) (aws#31403)

### Reason for this change



The [PR](aws#31402) created a new method to get CloudFront DNS name in Cognito user pool domain. A custom resource is created in the old method, but is not in the new method.

However, the `UserPoolDomainTarget` in the `route53-targets` module continues to use the old method. So we should change to use the new method.

### Description of changes



The `bind` method in the `UserPoolDomainTarget` implements `IAliasRecordTarget` interface, so a new method instead of the `bind` cannot be created.

Therefore, I take it using a feature flag.

### Description of how you validated changes



Both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
go-to-k authored Dec 11, 2024
1 parent ca01a25 commit 5e73dd0
Show file tree
Hide file tree
Showing 14 changed files with 733 additions and 4 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5e73dd0

Please sign in to comment.