Added icon support to ContextMenu (windows only) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, the tests are failing because I need to update them to expect the new images, will do ASAP and merge. Thanks for contributing! |
|
hey, sorry for the long delay! finally got around to fixing the code and merging now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
I've added support for icons in the ContextMenu class, but only for windows (tested in win10 and win11). I honestly have no ideia how to do it for Nautilus, so be my guest 😊.
I've updated the documentation in Advanced Usage section (although I've not provided an example) and the pytest code. For some reason I could not run it, but I've been running this code for a while now in a personal project and it's working so far.
Here's a screenshot of it working:
