Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

Fix PHP 7.4 bug #159 #160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mstralka
Copy link

@mstralka mstralka commented Jun 2, 2020

Sorry for the reformatting this was really only a few changes to fix #159 by changing several instances of:

if ($this->tenantTokens[$tenantKey] == null) {

to

if (!isset($this->tenantTokens[$tenantKey]) || $this->tenantTokens[$tenantKey] == null) {

and initializing $this->tenantTokens in the constructor instead of a local variable.

@iisisrael
Copy link

Can this be rebased on the latest instead of the 1.2.2 version?

Also, this change could be added, since it's for the same reason. It's confirmed by the existing CacheServiceTest::testWhenNewInstanceIsCreatedGetReturnsNull().

@iisisrael
Copy link

Actually this change as well.

@rgarnica
Copy link

rgarnica commented Sep 4, 2020

Hi, what is missing to merge this? Could I help with something to get this merged?

@ping86
Copy link

ping86 commented Sep 29, 2020

I have the same issue. Changes looks well 👍

@stef686
Copy link

stef686 commented Jan 8, 2021

Any news on getting this merged?

@simonmc3
Copy link

Yes, I would certainly benefit from this fix.

@faelgabriel
Copy link

@manivinesh @sfdrogojan could you guys help us with that?

@boxyashish
Copy link

can someone please merge this PR to master branch, as we need this fix asap

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to validate App Keys(ClientID/ClientSecret) w/ Php 7.4.x [BUG]
8 participants