This repository has been archived by the owner on May 30, 2023. It is now read-only.
Bugfix: lightning combobox triggers virtual keyboard on touch devices #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @chirag64 to sign the Salesforce.com Contributor License Agreement. |
|
up |
SauravJ21
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue:
User opens a web page with a
lightning-comboboxlike https://developer.salesforce.com/docs/component-library/bundle/lightning-combobox/example on an Android or iOS device and taps on the combobox to open it.Actual behavior:
Virtual keyboard on iOS and Android opens up
Expected behavior:
Virtual keyboard on iOS or Android should not open up as the user is supposed to select a value, not type in the combobox
Fix:
As per MDN,
inputmode="none"when applied to an input tag will stop the trigger of virtual keyboard from happeningI'm aware that you are not accepting Pull Requests, but I'm hoping you can make an exception for this small change or at least acknowledge & fix this issue from your end soon.