Skip to content

Commit

Permalink
chore: filter @lwc/engine-server fixture test warnings for `lwc:dyn…
Browse files Browse the repository at this point in the history
…amic` only (#4072)

* chore: filter engine-server warnings for lwc:dynamic only

* chore: add comment for warning
  • Loading branch information
jmsjtu committed Mar 18, 2024
1 parent ec3aa31 commit 4008342
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion packages/@lwc/engine-server/src/__tests__/fixtures.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,12 @@ async function compileFixture({ input, dirname }: { input: string; dirname: stri
}),
],
onwarn(warning) {
warnings.push(warning);
if (warning.message.includes('LWC1187')) {
// TODO [#3331]: The existing lwc:dynamic fixture test will generate warnings that can be safely suppressed.
// The warning message is expected and appears when the compiler detects usage of the directive.
// We plan to remove the directive in a future release, see #3331 for details.
warnings.push(warning);
}
},
});

Expand Down

0 comments on commit 4008342

Please sign in to comment.