Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update engines.node version to v16 #4188

Closed
wants to merge 2 commits into from

Conversation

ekashida
Copy link
Member

@ekashida ekashida commented Apr 30, 2024

Details

v18.18.0 seems like a reasonable minimum supported node version considering our project doesn't build successfully using anything below that.

Conservatively update to v16 since our internal systems are still in the process of migrating to v18/v20.

Does this pull request introduce a breaking change?

  • 💔 Yes, it does introduce a breaking change.

GUS work item

W-15647787

@ekashida ekashida added this to the 7.0.0 milestone Apr 30, 2024
@ekashida ekashida requested a review from a team as a code owner April 30, 2024 23:39
@ekashida ekashida changed the title chore: update engines.node version to v18.18.0 chore: update engines.node version to v16 May 1, 2024
Copy link
Collaborator

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit confusing, but the engines version in the root package.json doesn't actually do anything for consumers. It only affects us and our CI tests and local dev machines.

I would recommend modifying check-and-rewrite-package-json.js to read from the root package.json file and write the engines into each of our sub-packages.

@nolanlawson
Copy link
Collaborator

nolanlawson commented May 1, 2024

Ugh, I just realized that the lwc package's package.json isn't modified by that script... maybe we are better off removing engines from the root package.json entirely, putting it in the lwc package's package.json, and reading it from there.

@nolanlawson nolanlawson modified the milestones: 7.0.0, 8.0.0 May 6, 2024
@nolanlawson
Copy link
Collaborator

Deferred to LWC v8.0.0 so that we can bump directly to Node v18 or v20.

@wjhsf
Copy link
Contributor

wjhsf commented Aug 30, 2024

Jumping straight to node 20 in #4484.

@wjhsf wjhsf closed this Aug 30, 2024
@wjhsf wjhsf deleted the ekashida/engine-node branch August 30, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants