Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support v6 engine + v7 compiler #4315

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix: support v6 engine + v7 compiler #4315

merged 2 commits into from
Jun 25, 2024

Conversation

nolanlawson
Copy link
Collaborator

Details

Re-do of #4314

Related: #4313

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

GUS work item

@nolanlawson nolanlawson requested a review from a team as a code owner June 21, 2024 16:37
className: api_normalize_class_name($cmp.barClass),
className: api_normalize_class_name
? api_normalize_class_name($cmp.barClass)
: $cmp.barClass,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This basically illustrates the fix right here. The older engine doesn't have this api method.

@nolanlawson nolanlawson merged commit 5003e1e into master Jun 25, 2024
10 checks passed
@nolanlawson nolanlawson deleted the nolan/v6-engine branch June 25, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants