Fix: Ensure insertBefore throws an error when called with incorrect number of arguments #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umber of arguments
|
Thanks for the contribution! Before we can merge this, we need @manoharsiriki to sign the Salesforce Inc. Contributor License Agreement. |
nolanlawson
reviewed
Jun 25, 2024
| @@ -66,6 +66,9 @@ function monkeyPatchDomAPIs() { | |||
| return callNodeSlot(appendedNode, ConnectingSlot); | |||
| }, | |||
| insertBefore(newChild, referenceNode) { | |||
| if (arguments.length < 2) { | |||
| throw new TypeError("Failed to execute 'insertBefore' on 'Node': 2 arguments required, but only 1 present."); | |||
There was a problem hiding this comment.
Thank you for this contribution @manoharsiriki ! Unfortunately we cannot merge this PR as-is. The problem is that our existing users may be relying on the behavior where insertBefore(foo) does not throw an error and silently "works" the same as insertBefore(foo, undefined).
Could you instead please add a logWarnOnce here to tell the user that they are using an unsupported API? And please add a test to assert that the warning is called, using toLogWarningDev?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item