feat: add data-lwc-host-mutated during SSR
#4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jul 3, 2024
|
|
||
| export default class Child extends LightningElement { | ||
| @api foo; |
There was a problem hiding this comment.
Removes a warning, because I wanted to test that there are no warnings.
wjhsf
approved these changes
Jul 5, 2024
Comment on lines
+4
to
+7
| yolo = 'woot'; | ||
|
|
||
| connectedCallback() { | ||
| this.setAttribute('data-mutatis', 'mutandis'); |
| import { LightningElement } from 'lwc'; | ||
|
|
||
| export default class Child extends LightningElement { | ||
| yolo = 'woot'; |
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
This was referenced Jul 8, 2024
divmain
approved these changes
Jul 8, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Detects when an SSR'd component mutates its own host element (e.g. adding/removing classes/attributes) during its
connectedCallback, adding adata-lwc-host-mutatedattribute. This attribute is read during hydration time, and validation for the element's classes/attrs is skipped entirely, the same as if the component had explicitly setstatic validationOptOut = true.The goal is to make it easier for component authors to ignore small hydration errors caused by mutating their hosts during
connectedCallback.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
Kinda? But this is for SSR, which is not officially supported yet, and this removes restrictions rather than adding them.
GUS work item