-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a link to the older version of Salsa in the document #451
Conversation
❌ Deploy Preview for salsa-rs failed.
|
456ce92
to
69c1417
Compare
Awesome! 👍 In regards to #448, I think this PR solves the issue for users of the older (i.e., "go read this instead"), while it unfortunately still doesn't avoid confusion for users of the new version. |
@oeb25 Yes, you're correct. This PR doesn't completely address issue #448. Therefore, I updated the PR's description from "close 448" to "related to 448". This means that the issue will not be closed when the PR is merged. |
Thanks for your patience. I am slowly (slowly) coming back online here. This looks like a good start. It'd be nice to modify the book here to just have both versions, I suppose, rather than redirecting to an external site. How hard would that be? |
69c1417
to
fa4dc3c
Compare
@nikomatsakis I've set up the book to support both versions by utilizing URL paths:
To make this work on our repo, we'll need to modify the publish directory from My build settings: I lack the permissions to make this change, but I believe you can assist :) |
@xffxff this looks cool, yes, thank you! Let me look into making that change. |
I updated the permissions and decided to throw the dice 🎲 and merge the PR. Let's see what happens! |
Any thoughts ;) |
Might be I need to modify the run |
Never mind, I think I see the problem. |
related to #448
As Salsa-2022 is no yet complete and it is still unstable, there are some users who continue to use the old version of Salsa, or prefer using it due to its more stable API. Therefore, I think it is necessary to re-deploy the book for the older version of Salsa.
I have deployed the book for the older version from commit 754eea8b5f8a31b1100ba313d59e41260b494225 of Salsa on https://old-salsa-rs.netlify.app/