[breaking-salsa-2022] Debug with db: ignore deps, support customization #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous PR we added the `include_all_fields` parameter to `DebugWithDb` to allow it to not create spurious dependencies. This PR takes a different approach: we simply ignore the dependencies created during debug operations. This is risky as it can create incorrect dependencies, but it is way more convenient and seems like what users probably want. It also means that `DebugWithDb` has a simpler signature that matches the `Debug` trait again, which seems good to me.
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
reviewed
Jun 19, 2024
Comment on lines
+96
to
+105
| impl DebugWithDb<dyn Db + '_> for DerivedCustom { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>, db: &dyn Db) -> std::fmt::Result { | ||
| write!( | ||
| f, | ||
| "{:?} / {:?}", | ||
| self.my_input(db).debug(db), | ||
| self.value(db) | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice: That's something I've come across too where some tracked structs have fields that are salsa ingredients and the "default" generated DebugWithDb implementation didn't emit them with debug. Thanks for making this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how
DebugWithDbworks:include_all_fieldsflag is removed (it was annoying).#[customize(DebugWithDb)]to skip generating the impl for a given type.I think overall this is an improvement, though it is a breaking change.