Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused dependencies #505

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Remove some unused dependencies #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3807013
Remove some unused dependencies
mbrobbel Jun 19, 2024
396c4a4
Also remove `env_logger`
mbrobbel Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ description = "A generic framework for on-demand, incrementalized computation (e
[dependencies]
arc-swap = "1.6.0"
crossbeam = "0.8.1"
crossbeam-utils = { version = "0.8", default-features = false }
dashmap = "5.3.4"
hashlink = "0.8.0"
indexmap = "2"
Expand All @@ -22,12 +21,10 @@ smallvec = "1.0.0"

[dev-dependencies]
derive-new = "0.5.9"
env_logger = "*"
expect-test = "1.4.0"
eyre = "0.6.8"
notify-debouncer-mini = "0.2.1"
ordered-float = "3.0"
parking_lot = "0.12.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think env_logger can also be removed. It changes the output of one test because cargo wont suggest a type from the env_logger crate anymore but I'm not sure if it's work keeping a dependency just because of that.

rustversion = "1.0"
test-log = "0.2.11"
trybuild = "1.0"
Expand Down
2 changes: 0 additions & 2 deletions components/salsa-macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ description = "Procedural macros for the salsa crate"
proc-macro = true

[dependencies]
eyre = "0.6.5"
heck = "0.4"
proc-macro2 = "1.0"
quote = "1.0"
syn = { version = "2.0.64", features = ["full", "visit-mut"] }
Expand Down
2 changes: 1 addition & 1 deletion src/function/lru.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::{hash::FxLinkedHashSet, Id};

use crossbeam_utils::atomic::AtomicCell;
use crossbeam::atomic::AtomicCell;
use parking_lot::Mutex;

#[derive(Default)]
Expand Down
2 changes: 1 addition & 1 deletion src/function/memo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use std::sync::Arc;

use arc_swap::{ArcSwap, Guard};
use crossbeam_utils::atomic::AtomicCell;
use crossbeam::atomic::AtomicCell;

use crate::{
hash::FxDashMap, key::DatabaseKeyIndex, runtime::local_state::QueryRevisions, Event, EventKind,
Expand Down
3 changes: 0 additions & 3 deletions tests/compile-fail/singleton_only_for_input.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ error[E0432]: unresolved imports `common::HasLogger`, `common::Logger`
| ^^^^^^^^^ ^^^^^^ no `Logger` in `common`
| |
| no `HasLogger` in `common`
|
= help: consider importing this struct instead:
env_logger::Logger

error[E0412]: cannot find type `MyTracked` in this scope
--> tests/compile-fail/singleton_only_for_input.rs:11:21
Expand Down
Loading