re-enable parallel tests #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using "peek fields" methods instead; I like that approach better.
We are going to want to take databases at public entry points.
We can use this to more reliably sort.
We used to sort just by the ingredient index, but since those are now added dynamically, that can be fairly unstable in some of the tests. We now sort by the "debug name" of the ingredient first, which is more reliably stable.
I realized there weren't any!
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
reviewed
Jul 24, 2024
There was a problem hiding this comment.
I like the idea of a handle. It also removes the need for implementing a snapshot function on any other field stored on Db (which normally involves wrapping that field in an Arc).
The only thing that I'm slightly concerned about is the cost of using thread locals for every Salsa operation.
src/handle.rs
Outdated
| @@ -49,6 +49,12 @@ impl<Db: HasStorage> Handle<Db> { | |||
| let storage = self.db.storage(); | |||
| storage.runtime().set_cancellation_flag(); | |||
|
|
|||
| self.db.salsa_event(Event { | |||
There was a problem hiding this comment.
Nit: We could probably use an AtomicUsize for clones
There was a problem hiding this comment.
Yes, we could, we do need a mutex for signalling. This is simpler.
interesting, I don't see this... |
Sigh, I always make this mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch re-enables the parallel tests. It does not yet add the nicer parallel APIs imagined for Salsa 3.0.
Changes:
salsa::Handle, which can simply be cloned.get_mutmethod on theHandleis called, any outstanding clones will be cancelled (I added a test for this).