Update expect test output to account for OrderedFloat changes #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #545 will not alter performanceComparing Summary
|
|
Is it expected that Miri is currently unhappy in main? |
carljm
changed the title
carljm
changed the title
Yes, MIRI isn't happy with the concurrent vec dependency. |
MichaReiser
approved these changes
Jul 30, 2024
|
We should consider running examples as part of CI |
They are run as part of CI; I discovered this failure because this test failed on my other PR. |
github-merge-queue
bot
closed this pull request by merging all changes
into
salsa-rs:master
in
994c988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
expect!tests for the parser example are failing in main branch. This failure started with c50cefa which upgraded theordered-floatdependency. It looks like the new version of ordered-float implementsDisplayas a pass-through to the underlying float, and the old version did not, causing these test failures.Generated by running
env UPDATE_EXPECT=1 cargo test --workspace --all-features --all-targets.