[WIP] [3006.x] Add once option to logging so we stop spamming logs with useless info #66826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
dwoz
changed the title
bdrx312
reviewed
Aug 24, 2024
Comment on lines
+245
to
+247
| if str(args) in self.ONCECACHE: | ||
| return | ||
| self.ONCECACHE.add(str(args)) |
There was a problem hiding this comment.
This is going to prevent the str from being garbage collected which could be a problem for long running processes.
There was a problem hiding this comment.
Yes, the strings are cached forever. This won't be an endlessly growing cache though. As of now I've only identified one place in the code where this feature is really needed. So, as long as the once option is used sparingly I think it's okay.
dmurphy18
approved these changes
Aug 26, 2024
bdrx312
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.