-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Add state.sls_exists to ssh client #66894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go on the master branch since this is a new feature. The .. versionadded::
needs to be 3008.0
cc77290
to
13d6f66
Compare
Looks like the CI release job is failing as it started before I changed the target branch back to |
Maybe it needs to be |
13d6f66
to
932c256
Compare
There's no other instance of |
Yep, it's happy now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Could we get a changelog please?
fixes: saltstack#66893 Signed-off-by: Olivier Mehani <shtrom@ssji.net> Fix typo in sate.sls_exists doctstrings (module & ssh wrapper) Signed-off-by: Olivier Mehani <shtrom@ssji.net>
a1e372e
to
e64d7e9
Compare
Added Changelog, rebased on master, and squashed. |
What does this PR do?
Add state.sls_exists to the SSH wrapper
What issues does this PR fix or reference?
Fixes #66893
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.