Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add state.sls_exists to ssh client #66894

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

shtrom
Copy link
Contributor

@shtrom shtrom commented Sep 16, 2024

What does this PR do?

Add state.sls_exists to the SSH wrapper

What issues does this PR fix or reference?

Fixes #66893

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go on the master branch since this is a new feature. The .. versionadded:: needs to be 3008.0

@shtrom shtrom force-pushed the 66893_salt-ssh_state.sls_exists branch from cc77290 to 13d6f66 Compare September 18, 2024 08:17
@shtrom shtrom changed the base branch from 3007.x to master September 18, 2024 08:18
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [3007.x] Add state.sls_exists to ssh client [master] Add state.sls_exists to ssh client Sep 18, 2024
@shtrom shtrom requested a review from twangboy September 18, 2024 08:18
@shtrom
Copy link
Contributor Author

shtrom commented Sep 18, 2024

Looks like the CI release job is failing as it started before I changed the target branch back to master.

@twangboy
Copy link
Contributor

Maybe it needs to be .. versionadded:: Argon

@shtrom shtrom force-pushed the 66893_salt-ssh_state.sls_exists branch from 13d6f66 to 932c256 Compare September 19, 2024 08:07
@shtrom
Copy link
Contributor Author

shtrom commented Sep 19, 2024

There's no other instance of Argon as a version, but there are 3008.0. I just rewrote the top commit and force-pushed. If my previous hunch is correct, the tests should pass this time.

@shtrom
Copy link
Contributor Author

shtrom commented Sep 20, 2024

Yep, it's happy now!

Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Could we get a changelog please?

fixes: saltstack#66893

Signed-off-by: Olivier Mehani <shtrom@ssji.net>

Fix typo in sate.sls_exists doctstrings (module & ssh wrapper)

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
@shtrom shtrom force-pushed the 66893_salt-ssh_state.sls_exists branch from a1e372e to e64d7e9 Compare September 21, 2024 08:13
@shtrom
Copy link
Contributor Author

shtrom commented Sep 21, 2024

Added Changelog, rebased on master, and squashed.

@dwoz dwoz merged commit 15573a8 into saltstack:master Sep 26, 2024
182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] state.sls_exists not working with salt-ssh
6 participants