Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action #1453

Merged
merged 13 commits into from
Oct 27, 2024
Merged

github action #1453

merged 13 commits into from
Oct 27, 2024

Conversation

pcriadoperez
Copy link
Collaborator

@pcriadoperez pcriadoperez commented Oct 24, 2024

  • Adds ruff to github action (Currently continues in error until ruff #1452 is merged)
  • Creates three jobs: lint, build and finish.
    Lint to run ruff, build to run pytest, and pyright on each version
  • And finish to for the coveralls call. (Need to furhter test this on a PR that has a coverage change to see the report generated)
  • Move coveralls from python-coveralls to official github integration

@pcriadoperez pcriadoperez self-assigned this Oct 24, 2024
@carlosmiei
Copy link
Collaborator

@pcriadoperez why are we adding a new file here instead of doing the edits in place inside python-app.yml?

@pcriadoperez
Copy link
Collaborator Author

@pcriadoperez why are we adding a new file here instead of doing the edits in place inside python-app.yml?

I did it in a seperate file for testing, not to affect current action. But now moved it to the same file

@pcriadoperez pcriadoperez marked this pull request as ready for review October 27, 2024 11:28
@carlosmiei carlosmiei merged commit 4300214 into sammchardy:master Oct 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants