-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i858] - Enables chunked uploads for improved file upload reliability #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and efficiency Issue: - scientist-softserv/adventist_knapsack#858 Chunked uploads allow large files to be uploaded in smaller parts, addressing common issues with file size limits, network interruptions, and server resource management. This change supports smoother, more reliable uploads for large files in Bulkrax.
ShanaLMoore
force-pushed
the
i858-chunky-uploads
branch
from
October 28, 2024 23:20
93d99d7
to
f2c1ce9
Compare
ShanaLMoore
commented
Oct 29, 2024
… initialization - Moved Bulkrax file upload logic from bulkrax.js to importers.js to consolidate related logic - Added conditional check to initialize uploader only if `hyraxUploader` is defined as a function - Ensured toggle of 'required' attribute based on uploaded file presence for import form consistency
… into i858-chunky-uploads
ShanaLMoore
force-pushed
the
i858-chunky-uploads
branch
from
October 29, 2024 23:18
41cc329
to
de5f460
Compare
laritakr
approved these changes
Oct 30, 2024
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Chunked uploads allow large files to be uploaded in smaller parts, addressing common issues with file size limits, network interruptions, and server resource management.
This change supports smoother, more reliable uploads for large files in Bulkrax.
When a user uploads, multiple POST requests can be seen in the network tab because the uploads gets split into chunks. It's then handed to Hyrax controller to handle it on the server side.
DEMO:
CSV
if user tries to upload more than 1 file:
BAGIT
XML