Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public facing collections show page styling #2345

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

AKFosterDev
Copy link
Collaborator

Summary

This PR updates styling for the public facing collections show page. It addresses the top bars, the gallery view and pagination issues.

Related Ticket

Pals #137

Screenshots

image
image
image

@AKFosterDev AKFosterDev changed the title Collections show page styling DRAFT: Collections show page styling Sep 24, 2024
@AKFosterDev AKFosterDev requested review from kirkkwang and removed request for ShanaLMoore September 24, 2024 17:51
@AKFosterDev AKFosterDev changed the title DRAFT: Collections show page styling DRAFT: Public facing collections show page styling Sep 24, 2024
@AKFosterDev AKFosterDev added the patch-ver for release notes label Sep 24, 2024
@AKFosterDev AKFosterDev changed the title DRAFT: Public facing collections show page styling Public facing collections show page styling Sep 24, 2024
Copy link

Test Results

    3 files  ±0      3 suites  ±0   18m 10s ⏱️ +6s
2 038 tests ±0  1 988 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 065 runs  ±0  2 013 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit 033b603. ± Comparison against base commit 394fc04.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 0cf8e02b-ef37-4b31-b2c6-9991aa8ad528
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit fc5dc9ea-f07f-4f28-ae76-3be87a4f8b20
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ba7c5f4d-1aad-42c3-8eb1-df4f8db41024
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 0076179c-9bd3-4287-b26d-a6086a7f018c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 14740f1b-5c65-4d80-87f4-3c84d54339da
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit ba96e857-2dc8-43df-83ae-e68d6550a105
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 9cebfac4-cbef-4ceb-9b09-194d503e62c2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 569fa887-c6d5-472f-928e-478c87b59a3a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 49dc2470-9e5a-4d4b-b49c-b24f132a8ec9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit cae37d4b-e36e-4d23-b639-5250274e5694
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy fb5f1b4d-3b7e-44a7-811d-500a4580c8a0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 9305f818-bbfb-485c-90cb-b9f520001d50
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read a19b76e2-13ee-499e-ac0c-cbe86551787c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update adc9f415-23b3-4a62-a27c-1001ae41c04f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy fc807eba-05d1-413b-bd6f-3a8d0524f5ec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit b54ff285-b69b-4bf5-b7fa-a74c3dee207e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read b6eeb767-b5e6-47c8-a4c3-ea53c7751584
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 4a8a21f9-54a5-49cd-a5f9-b3c14db24a11
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 1595b30d-f458-44d8-ad30-609dbffaf544
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5c7aae04-6f76-463b-98c7-9abcd4237534
…

@AKFosterDev AKFosterDev merged commit 6041d6c into main Sep 24, 2024
8 checks passed
@AKFosterDev AKFosterDev deleted the i137_collection_show_styling branch September 24, 2024 19:27
@laritakr laritakr mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants