Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix universal viewer duplicates #2346

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

laritakr
Copy link
Collaborator

Refs scientist-softserv/adventist_knapsack#817

Updates IiifPrint to bring in fixes re: items list duplication.
Uses new index field to get full list of file set ids, since member_ids_ssim index override has been removed.

Member ids definition has been modified for IiifPrint so it no longer
includes the child works file sets. This patch adjusts for that change.
Brings in most recent patches from IiifPrint.
@laritakr laritakr added the patch-ver for release notes label Sep 25, 2024
Copy link

Test Results

    3 files  ±0      3 suites  ±0   18m 28s ⏱️ +38s
2 038 tests ±0  1 988 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 065 runs  ±0  2 013 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit ea4ddb0. ± Comparison against base commit 6041d6c.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 5aadca84-45c6-4613-b11d-3fa38f9d1ccc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit da90fef9-539a-42ef-8707-83b5a3de46f8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 7c5bf4cd-20dc-4acd-84c3-95cbf272d496
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update cc170844-b393-49c1-a4da-98052efe49a8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 1b0a8c17-9876-4e05-85e6-771da9c4bd69
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit e9b299dc-ce3e-4f5a-9f87-5b77bc636820
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read e6d4c024-8bba-4bd3-9aa0-d4e100f5e5a8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 2fd69cfb-63a1-4865-aff3-b4b192e7271c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 558f5afb-c2af-4237-962d-9c4e1ef4c98a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit e30bf171-1f10-4df8-aeb4-2b575e51aabd
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 54f37b60-b683-4dff-b6d0-b7b213df7de0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit bf6a0fc9-b51a-491a-bc33-e3bc19af1d1f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 49652651-b761-4265-b766-a918c3daef8d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update ad4024bc-0375-4f84-b00c-f09ea8f2224f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 30a31979-64a8-4b17-9557-1e7f1dfff433
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 6b58db0d-d414-455a-a0a9-a3156ad7dd8e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 8e2a90b0-9823-4769-9214-fb388822129d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 7529ca5d-42e4-4191-b0dd-aec393b83b5a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy e9f2ff9d-f471-469a-b6ba-7092cd0c5143
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 29ca99f0-9768-4cec-85b5-ea9a22163901
…

@laritakr laritakr merged commit 5ceb29a into main Sep 25, 2024
8 of 9 checks passed
@laritakr laritakr deleted the fix-universal-viewer-duplicates branch September 25, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants