Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hyrax, fix institutional repository layout & based_near behavior #2361

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Oct 17, 2024

Summary

refs

Fixes:

  • header text position in institutional repository
  • location faceting (a reindex will get works using based_near to appear in the facet if they are missing)
  • based_near behavior fixes for ETD and OER resources types

Changes proposed in this pull request:

  • update hyrax
  • fix institutional repository layout
  • ensure all resource types have based_near behavior that works

Screenshots

Institutional Repository layout after changes

With Logo

Screenshot 2024-10-17 at 2 37 22 PM

Without Logo

Screenshot 2024-10-17 at 2 38 22 PM

Based near is now working

Screenshot 2024-10-17 at 6 30 14 PM

@samvera/hyku-code-reviewers

Removes duplication of application name when there is no logo.
Repositions application name to be centered between logo and search bar.

Fixes #2356
@laritakr laritakr added the patch-ver for release notes label Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 41s ⏱️ + 2m 27s
2 038 tests ±0  1 988 ✅ +128  50 💤 ±0  0 ❌  - 128 
2 065 runs  ±0  2 013 ✅ +128  52 💤 ±0  0 ❌  - 128 

Results for commit 16193de. ± Comparison against base commit 335eea4.

This pull request removes 43 and adds 43 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy acea78cb-0841-4d85-b0fd-ecd74a62a6b3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit a7f333d5-4e89-49ce-8425-4960632daeb1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f6d822ed-0fec-4110-a96b-3fd367065713
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 5613737e-6ea9-42fc-a570-b6c4324f0132
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 3e97f88e-96d9-48e4-a40d-5b907901a8db
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit cb6ca417-81f5-4e0f-9e8a-8599a0efd75d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 313e71cc-4288-43f6-9900-15db09e5772a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 4efe2425-e3fc-4df9-b1f6-e2dd80ef6921
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy f65eabe0-2f57-499c-82e1-a36983a2c8b5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 089cc01b-6dfc-4073-9acf-4852f1493987
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 212a4776-8377-4991-bf04-24e789dd6954
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit e3089545-7f01-4cc0-9230-43332ef6d136
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read e978f2f9-9f36-429f-840b-7033c02ed36b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update c63132f6-922e-4d56-96da-f8fda64b2984
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 452f3a36-e5e0-40e2-ab7e-dadf14f9b622
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 618f63d1-07c1-442d-8288-8a49368f8a3f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 753a0da7-06d9-47d0-bbd9-bd724ed21215
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 3caf9b92-2f6c-4f6b-9441-a441c60516be
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy b130017d-cb74-4931-8535-f914220ba8a9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 6c26c0d6-d29b-4ca1-b04f-61bdae96b65d
…

♻️ This comment has been updated with latest results.

When basic_metadata isn't part of the schema, the based_near
prepopulators don't get included via form_fields.rb.

This is including them explicitly to avoidbroken based_near
behaviors in the forms.
@laritakr laritakr changed the title Update hyrax Update hyrax, fix institutional repository layout & based_near behavior Oct 17, 2024
@laritakr laritakr marked this pull request as draft October 17, 2024 21:17
@laritakr laritakr marked this pull request as ready for review October 17, 2024 22:29
@laritakr laritakr merged commit 6931967 into main Oct 17, 2024
8 checks passed
@laritakr laritakr deleted the update-hyrax branch October 17, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants