Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for views & branding #2386

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Small fixes for views & branding #2386

merged 5 commits into from
Nov 21, 2024

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Nov 20, 2024

Incorporates several small fixes:

  • Moves several partials for the OER work type that was contributed back from pals and weren't included previously
  • Collection metadata now shows text for based_near location instead of URI
  • Fix collection branding (banner & logo)

Ref scientist-softserv/palni_palci_knapsack#165

@laritakr laritakr added the patch-ver for release notes label Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Test Results

    3 files  ±0      3 suites  ±0   18m 22s ⏱️ +23s
2 047 tests +7  1 997 ✅ +7  50 💤 ±0  0 ❌ ±0 
2 074 runs  +7  2 022 ✅ +7  52 💤 ±0  0 ❌ ±0 

Results for commit 9f5a5ec. ± Comparison against base commit 2ea73b9.

This pull request removes 42 and adds 49 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 41f860dc-5377-44b5-afe7-c219233d157c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 00c81bee-60c8-4965-a3bc-f491078ffdb9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 809b1def-0a6d-4079-bd97-45383a7a10d4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 4a7f6a2a-2cad-4445-9db5-dd6184e6f87f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 52b2c4c3-41d0-4d78-b921-2e040231086f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 46047960-610f-412f-bd22-12fd2fefecc3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 3c2180b6-62c8-4200-a8da-91aa950a8bed
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update d4f702cb-e5b6-4c35-8de2-c3badb8d9581
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 3ca1598a-fbfe-49a2-aac7-7821d2dffaac
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit ee2e2cea-c450-47a2-8287-2b1bb3a2227d
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy eb6c1018-fb2a-426c-8382-52fd5dd41634
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 05a28d63-185a-4d3f-85ee-d06a47d786cb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 7bc8650e-6956-406c-b284-bcabd36b4e1d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 36f3d5f4-1bef-4770-bb55-073f9e29c5d2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy f4a65d92-4ad4-44df-a131-20d01eda4667
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 9c40272a-fdb1-45f3-8888-fad08eaa0cb7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 8ec64ad8-84bb-482a-97ab-d005f87f05bd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update d529241a-3387-4aca-b371-cb661b687133
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 8ea56534-8bb5-44db-88fa-0dc3b20ffa6a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 3d0637ce-4254-4d19-b049-be120a8e351e
…

♻️ This comment has been updated with latest results.

Indicators default to true... not loading them prevented branding.
@laritakr laritakr changed the title Move oers partials from pals repo Small fixes for views & branding Nov 21, 2024
bkiahstroud
bkiahstroud previously approved these changes Nov 21, 2024
Added "Other"
@laritakr laritakr merged commit 571c2de into main Nov 21, 2024
8 checks passed
@laritakr laritakr deleted the move-code-from-pals branch November 21, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants