Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #153 Added attributes for sheet definitions to customise preview image more #154

Merged
merged 21 commits into from
May 14, 2024

Conversation

ReneeIbeji
Copy link

Added 3 attributes that can be used in the items sheet definitions :

  • preview_column - Represents which sprite on a row to use as the preview image (default 0)
  • preview_x_offset - The amount of pixels on the x axis the preview image frame is offsetted by in reference to the preview column set. (default 0)
  • preview_y_offset - The amount of pixels on the y axis the preview image frame is offsetted by in reference to the preview row set.
    (default 0)

Please note the default value for the preview row is 10.
I've used these new attributes to fix the preview images for all the spear items so far.

@jrconway3
Copy link

I'll try testing this out later to see if I can get it working.

@jrconway3
Copy link

Finally got a chance to look, forgot about this before. Looking pretty good! Its really great being able to see weapon previews finally. Sucks we have to manually make changes to showcase the correct preview, but at least the option is there. It also lets us pick out a better preview it a different preview might look better, too.

@sanderfrenken
Copy link
Owner

I see you need to rebase, there are some conflicts. Thanks for the contribution already!

sources/chargen.js Outdated Show resolved Hide resolved
@ReneeIbeji
Copy link
Author

OK, I don't think their should be any issues now

@sanderfrenken sanderfrenken merged commit c01ea10 into sanderfrenken:master May 14, 2024
1 check passed
@ReneeIbeji ReneeIbeji deleted the Preview-Image-Changes branch May 14, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants