Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #141 Mapped All of Eliza's Helmets (Plus A Few More) #171

Merged

Conversation

jrconway3
Copy link

Fixed positioning for helmets here:
#141

All of Eliza's helmets are mapped, and I did a few more but not all of them just yet. I did all the Bascinets but I haven't touched the Visors yet. I also added Plumage. Eliza has the Plumage in two different positions, but I didn't bother with that here and just kept it in the same place.

During this process I noticed many helmets were slightly off position, so I made sure they were properly centered on the head in a consistent way. I'll fix the visors and remaining helmets next time.

Sword will probably be the next asset I work on from Eliza but its looking relatively complicated. There's a crap ton of shield assets I really don't want to mess with right now, so I'll probably worry about that later.

@sanderfrenken sanderfrenken merged commit 25c5641 into sanderfrenken:master Jun 5, 2024
1 check passed
@jrconway3
Copy link
Author

I realize what I did wrong now. All the male assets are mapped correctly while the female assets are legacy and aren't being used anymore. Most of the helmet assets were only showing male. Simplifying it to the updated "adult" / "child" structure (even without child assets) makes this cleaner and easier to understand, as the "female" helmet assets are literally just taking up space now that they're been merged into one.

I'm using "male" now for the remaining helmets and no adjustments are needed to the base universal set. Just need to apply the new frame positions now.

@jrconway3 jrconway3 deleted the issue-141-map-helmets-all-frames branch September 16, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants