Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Issue #141 Added 6 Patterns to All Frames, Added Revised Frames to "Original" Heater Shield Layout" #185

Conversation

jrconway3
Copy link

For Issue #141 I added the following:

  • Heater Shield Pattern: Barry (All Frames)
  • Heater Shield Pattern: Bend (All Frames)
  • Heater Shield Pattern: Bend Sinister (All Frames)
  • Heater Shield Pattern: Bordure (All Frames)
  • Heater Shield Pattern: Chevron (All Frames)
  • Heater Shield Pattern: Chevron Inverted (All Frames)
  • Heater Shield Pattern: Saltire (All Frames)
  • "Original" Heater Shield Layout To All Frames

For the last entry, I just kept the original Heater Shield layout bluecarrot did for the classic "universal" set, but kept all the front/back assets for the new animation frames I added. I'm going to keep both versions going forward.

Potentially I might revert some assets, because I tested the walk animations and some of them look weird with the shield. I'm not certain yet if I want to this.

…ron Inverted, and Saltire Patterns to All Frames, Added All Frames Version of Original Heater Shield Layout
@sanderfrenken sanderfrenken merged commit 5a2a394 into sanderfrenken:master Sep 3, 2024
1 check passed
@fnaith
Copy link

fnaith commented Sep 3, 2024

Hello @jrconway3,

In following files, layer_1 doesn't have teen field as layer_2 :
shield_heater_pattern_chevron_inverted.json
shield_heater_revised_pattern_chevron_inverted.json

Is that expected ?

@jrconway3
Copy link
Author

Hello @jrconway3,

In following files, layer_1 doesn't have teen field as layer_2 : shield_heater_pattern_chevron_inverted.json shield_heater_revised_pattern_chevron_inverted.json

Is that expected ?

Definitely not. I have it fixed for the next update now. Thanks for pointing it out.

@jrconway3 jrconway3 deleted the issue-141-add-additional-patterns branch September 16, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants