Skip to content

Commit

Permalink
IMSC reader: fix default values for tts:textEmphasis
Browse files Browse the repository at this point in the history
  • Loading branch information
palemieux authored Sep 1, 2023
1 parent 09e557a commit 82260e8
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/main/python/ttconv/imsc/style_properties.py
Original file line number Diff line number Diff line change
Expand Up @@ -868,8 +868,8 @@ def extract(cls, context: StyleParsingContext, xml_attrib: str):

else:

style_style = style_style if style_style is not None else "circle"
style_symbol = style_symbol if style_symbol is not None else "filled"
style_style = style_style if style_style is not None else "filled"
style_symbol = style_symbol if style_symbol is not None else "circle"
style = styles.TextEmphasisType.Style(f"{style_style} {style_symbol}")

position = position if position is not None else styles.TextEmphasisType.Position.outside
Expand Down
18 changes: 18 additions & 0 deletions src/test/python/test_imsc_reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import ttconv.model as model
import ttconv.style_properties as styles
import ttconv.imsc.reader as imsc_reader
import ttconv.imsc.style_properties as imsc_styles

class IMSCReaderTest(unittest.TestCase):

Expand Down Expand Up @@ -241,5 +242,22 @@ def test_ooo_set_element(self):
if len(logs.output) != 2:
self.fail(logs.output)

def test_text_emphasis(self):
value = imsc_styles.StyleProperties.TextEmphasis.extract(None, "dot after")
self.assertEqual(value.style, styles.TextEmphasisType.Style.filled_dot)
self.assertEqual(value.position, styles.TextEmphasisType.Position.after)

value = imsc_styles.StyleProperties.TextEmphasis.extract(None, "dot before")
self.assertEqual(value.style, styles.TextEmphasisType.Style.filled_dot)
self.assertEqual(value.position, styles.TextEmphasisType.Position.before)

value = imsc_styles.StyleProperties.TextEmphasis.extract(None, "filled after")
self.assertEqual(value.style, styles.TextEmphasisType.Style.filled_circle)
self.assertEqual(value.position, styles.TextEmphasisType.Position.after)

value = imsc_styles.StyleProperties.TextEmphasis.extract(None, "open before")
self.assertEqual(value.style, styles.TextEmphasisType.Style.open_circle)
self.assertEqual(value.position, styles.TextEmphasisType.Position.before)

if __name__ == '__main__':
unittest.main()

0 comments on commit 82260e8

Please sign in to comment.