-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): refactor test config, enable vitest and migrate packages to vitest #5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
No changes to documentation |
Component Testing Report Updated Sep 25, 2024 9:55 AM (UTC) ✅ All Tests Passed -- expand for details
|
bjoerge
requested review from
binoy14,
stipsan and
ricokahler
and removed request for
a team
September 23, 2024 09:35
binoy14
previously approved these changes
Sep 23, 2024
stipsan
previously approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent 💖
stipsan
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This PR should probably be rebase+merged instead of squash merged since the commits makes sense on their own.
This includes several improvements to our unit test setup:
@repo/dev-aliases
-package to make it a first class dependency (it's been a well-kept secret, tucked away in./packages
until now).@repo/test-config
internal pacakge that contains the test configuration for jest (and now also vitest) so it can be a proper (dev) dependency of packages that needs it. This makes it easier to maintain test configs, and also makes it easier to remove reliance on jest in the future.In addition I've done some minor cleanups and smaller factors, hopefully leaving the code in a better shape.
What to review
The commits here can be reviewed one-by-one.
Testing
I've made sure the following is still true:
pnpm test
)pnpm dev
)Beyond that, this PR should not require any additional tests.
Notes for release
n/a - internal