refactor(structure): cleanup RequestPermissionDialog #7571

drewlyton · 2024-10-02T08:29:27Z

Description

This PR cleans up some copy paste comment blocks in the RequestPermissionDialog component and telemetry files.

What to review

Comment changes
Derive length from note value

Testing

No testing necessary.

Notes for release

No release notes

vercel · 2024-10-02T08:29:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 8:40am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 8:40am
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 8:40am
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 8:40am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 8:40am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Oct 2, 2024 8:40am

drewlyton · 2024-10-02T08:31:38Z

packages/sanity/src/structure/components/requestPermissionDialog/RequestPermissionDialog.tsx

                  }}
                />

-                <Text align="right" muted size={1}>{`${noteLength}/${MAX_NOTE_LENGTH}`}</Text>
+                <Text align="right" muted size={1}>{`${note.length}/${MAX_NOTE_LENGTH}`}</Text>


One refactor change to derive the note length from the note state instead of having a separate state value for it - again removing copy pasta from another file

github-actions · 2024-10-02T08:32:11Z

No changes to documentation

github-actions · 2024-10-02T08:44:27Z

Component Testing Report Updated Oct 2, 2024 8:44 AM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	47s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	9s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	31s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	37s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	17s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	10s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	44s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 37s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 15s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	8s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	26s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	17s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	36s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-02T08:50:14Z

⚡️ Editor Performance Report

Updated Wed, 02 Oct 2024 08:50:13 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	17.5 efps (57ms)	18.2 efps (55ms)	-2ms (-3.5%)	✅
article (body)	62.9 efps (16ms)	59.9 efps (17ms)	+1ms (+5.0%)	✅
article (string inside object)	19.2 efps (52ms)	19.2 efps (52ms)	+0ms (-/-%)	✅
article (string inside array)	15.2 efps (66ms)	14.5 efps (69ms)	+3ms (+4.5%)	✅
recipe (name)	30.3 efps (33ms)	30.3 efps (33ms)	+0ms (-/-%)	✅
recipe (description)	33.3 efps (30ms)	33.9 efps (30ms)	-1ms (-1.7%)	✅
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (7ms)	+1ms (-/-%)	✅
synthetic (title)	14.5 efps (69ms)	14.9 efps (67ms)	-2ms (-2.9%)	✅
synthetic (string inside object)	15.5 efps (65ms)	15.6 efps (64ms)	-1ms (-0.8%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	57ms	63ms	69ms	185ms	1129ms	14.6s
article (body)	16ms	18ms	20ms	105ms	163ms	5.2s
article (string inside object)	52ms	55ms	60ms	122ms	885ms	8.5s
article (string inside array)	66ms	69ms	73ms	119ms	1626ms	9.5s
recipe (name)	33ms	35ms	39ms	51ms	42ms	10.8s
recipe (description)	30ms	32ms	36ms	146ms	63ms	6.5s
recipe (instructions)	6ms	8ms	9ms	10ms	0ms	3.3s
synthetic (title)	69ms	72ms	77ms	216ms	2249ms	17.9s
synthetic (string inside object)	65ms	66ms	71ms	239ms	1832ms	10.1s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	55ms	62ms	74ms	187ms	1154ms	14.3s
article (body)	17ms	18ms	25ms	152ms	187ms	5.4s
article (string inside object)	52ms	55ms	71ms	131ms	973ms	8.8s
article (string inside array)	69ms	75ms	86ms	142ms	1712ms	10.0s
recipe (name)	33ms	35ms	37ms	55ms	56ms	10.3s
recipe (description)	30ms	31ms	32ms	50ms	18ms	6.1s
recipe (instructions)	7ms	8ms	9ms	32ms	0ms	3.3s
synthetic (title)	67ms	71ms	79ms	298ms	2017ms	18.0s
synthetic (string inside object)	64ms	67ms	76ms	262ms	1854ms	9.9s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

rexxars

Thanks!

### Description This PR cleans up some copy paste comment blocks in the RequestPermissionDialog component and telemetry files. ### What to review - Comment changes - Derive length from note value ### Testing No testing necessary. ### Notes for release No release notes

chore(structure): cleanup RequestPermissionDialog comments

d3976c5

drewlyton commented Oct 2, 2024

View reviewed changes

drewlyton changed the title ~~chore(structure): cleanup RequestPermissionDialog comments~~ refactor(structure): cleanup RequestPermissionDialog Oct 2, 2024

vercel bot deployed to Preview – performance-studio October 2, 2024 08:32 View deployment

vercel bot deployed to Preview – page-building-studio October 2, 2024 08:32 View deployment

vercel bot deployed to Preview – test-studio October 2, 2024 08:32 View deployment

vercel bot deployed to Preview – test-next-studio October 2, 2024 08:36 View deployment

vercel bot deployed to Preview – test-compiled-studio October 2, 2024 08:40 View deployment

drewlyton marked this pull request as ready for review October 2, 2024 12:48

drewlyton requested review from a team as code owners October 2, 2024 12:48

drewlyton requested review from binoy14 and rexxars and removed request for a team October 2, 2024 12:48

rexxars approved these changes Oct 3, 2024

View reviewed changes

rexxars added this pull request to the merge queue Oct 3, 2024

Merged via the queue into next with commit 00f713b Oct 3, 2024
51 checks passed

rexxars deleted the chore/gro-2687 branch October 3, 2024 21:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(structure): cleanup RequestPermissionDialog #7571

refactor(structure): cleanup RequestPermissionDialog #7571

drewlyton commented Oct 2, 2024 •

edited

Loading

vercel bot commented Oct 2, 2024 •

edited

Loading

drewlyton Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

rexxars left a comment

refactor(structure): cleanup RequestPermissionDialog #7571

refactor(structure): cleanup RequestPermissionDialog #7571

Conversation

drewlyton commented Oct 2, 2024 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Oct 2, 2024 • edited Loading

drewlyton Oct 2, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

rexxars left a comment

Choose a reason for hiding this comment

drewlyton commented Oct 2, 2024 •

edited

Loading

vercel bot commented Oct 2, 2024 •

edited

Loading