chore(ci): use `efps` for job name, use node 20, clarify tag description #7596

rexxars · 2024-10-05T00:10:51Z

Description

Minor; it took me 15 seconds to figure out that reference tag meant npm tag, not git tag.
Also, "install" seems a bit wide for the job name since it does the whole run.
…and we might as well use Node 20, I'd say?

What to review

Changes make sense

Testing

Don't think this should affect anything

Notes for release

None

vercel · 2024-10-05T00:10:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 0:15am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 0:15am
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 0:15am
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 0:15am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 0:15am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Oct 5, 2024 0:15am

github-actions · 2024-10-05T00:11:50Z

No changes to documentation

github-actions · 2024-10-05T00:17:40Z

Component Testing Report Updated Oct 5, 2024 12:17 AM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	45s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	8s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	29s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	37s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	17s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	10s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	44s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 40s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 14s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	9s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	26s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	17s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	35s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-05T00:30:44Z

⚡️ Editor Performance Report

Updated Sat, 05 Oct 2024 00:30:43 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	17.9 efps (56ms)	18.0 efps (56ms)	-1ms (-0.9%)	✅
article (body)	56.7 efps (18ms)	63.3 efps (16ms)	-2ms (-10.5%)	✅
article (string inside object)	18.2 efps (55ms)	18.9 efps (53ms)	-2ms (-3.6%)	✅
article (string inside array)	14.7 efps (68ms)	14.7 efps (68ms)	+0ms (-/-%)	✅
recipe (name)	31.7 efps (32ms)	32.3 efps (31ms)	-1ms (-1.6%)	✅
recipe (description)	34.5 efps (29ms)	34.5 efps (29ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (6ms)	+0ms (-/-%)	✅
synthetic (title)	14.7 efps (68ms)	14.9 efps (67ms)	-1ms (-1.5%)	✅
synthetic (string inside object)	15.6 efps (64ms)	16.1 efps (62ms)	-2ms (-3.1%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	56ms	62ms	69ms	178ms	1082ms	14.8s
article (body)	18ms	20ms	24ms	206ms	230ms	5.8s
article (string inside object)	55ms	57ms	62ms	150ms	1020ms	8.9s
article (string inside array)	68ms	75ms	79ms	217ms	1678ms	9.8s
recipe (name)	32ms	34ms	40ms	71ms	46ms	10.3s
recipe (description)	29ms	31ms	34ms	56ms	1ms	6.2s
recipe (instructions)	6ms	8ms	9ms	24ms	0ms	3.3s
synthetic (title)	68ms	70ms	77ms	266ms	2017ms	17.7s
synthetic (string inside object)	64ms	68ms	74ms	220ms	1872ms	10.1s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	56ms	60ms	70ms	159ms	1094ms	14.9s
article (body)	16ms	18ms	20ms	160ms	181ms	5.2s
article (string inside object)	53ms	56ms	59ms	81ms	785ms	8.4s
article (string inside array)	68ms	71ms	84ms	178ms	1763ms	10.1s
recipe (name)	31ms	34ms	59ms	71ms	47ms	9.8s
recipe (description)	29ms	30ms	51ms	65ms	11ms	6.3s
recipe (instructions)	6ms	8ms	8ms	9ms	0ms	3.1s
synthetic (title)	67ms	70ms	87ms	141ms	2140ms	17.5s
synthetic (string inside object)	62ms	65ms	76ms	220ms	1771ms	9.5s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

…ion (#7596) ### Description Minor; it took me 15 seconds to figure out that reference tag meant npm tag, not git tag. Also, "install" seems a bit wide for the job name since it does the whole run. …and we might as well use Node 20, I'd say? ### What to review Changes make sense ### Testing Don't think this should affect anything ### Notes for release None

chore(ci): use efps for job name, use node 20, clarify tag description

487b3f5

rexxars requested a review from a team as a code owner October 5, 2024 00:10

rexxars requested review from ricokahler and removed request for a team October 5, 2024 00:10

ricokahler approved these changes Oct 5, 2024

View reviewed changes

vercel bot deployed to Preview – test-next-studio October 5, 2024 00:12 View deployment

vercel bot deployed to Preview – test-compiled-studio October 5, 2024 00:15 View deployment

rexxars added this pull request to the merge queue Oct 5, 2024

Merged via the queue into next with commit 9cad54b Oct 5, 2024
63 checks passed

rexxars deleted the chore/efps-tweaks branch October 5, 2024 14:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): use `efps` for job name, use node 20, clarify tag description #7596

chore(ci): use `efps` for job name, use node 20, clarify tag description #7596

rexxars commented Oct 5, 2024

vercel bot commented Oct 5, 2024 •

edited

Loading

github-actions bot commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

chore(ci): use efps for job name, use node 20, clarify tag description #7596

chore(ci): use efps for job name, use node 20, clarify tag description #7596

Conversation

rexxars commented Oct 5, 2024

Description

What to review

Testing

Notes for release

vercel bot commented Oct 5, 2024 • edited Loading

github-actions bot commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

chore(ci): use `efps` for job name, use node 20, clarify tag description #7596

chore(ci): use `efps` for job name, use node 20, clarify tag description #7596

vercel bot commented Oct 5, 2024 •

edited

Loading