Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): Add timezones to create release and to the release details #7795

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Nov 12, 2024

  • Add timezone to create release and to the release details
  • Update formating for the inputs
  • Make inputs readOnly

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 1:35pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 1:35pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 1:35pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 1:35pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 1:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 1:35pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Component Testing Report Updated Nov 13, 2024 1:32 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 39s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 39s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 42s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 39s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 53s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 12, 2024

⚡️ Editor Performance Report

Updated Wed, 13 Nov 2024 13:34:32 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.9 efps (59ms) 12.2 efps (82ms) +23ms (+39.0%) 🔴
article (body) 56.5 efps (18ms) 59.9 efps (17ms) -1ms (-5.6%)
article (string inside object) 18.5 efps (54ms) 13.3 efps (75ms) +21ms (+38.9%) 🔴
article (string inside array) 15.9 efps (63ms) 11.4 efps (88ms) +25ms (+38.9%) 🔴
recipe (name) 30.3 efps (33ms) 20.0 efps (50ms) +17ms (+51.5%) 🔴
recipe (description) 34.5 efps (29ms) 21.7 efps (46ms) +17ms (+58.6%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.9 efps (67ms) 5.7 efps (176ms) +109ms (+161.9%) 🔴
synthetic (string inside object) 15.2 efps (66ms) 6.1 efps (165ms) +99ms (+149.2%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 59ms 67ms 89ms 149ms 598ms 13.5s
article (body) 18ms 21ms 31ms 192ms 356ms 6.5s
article (string inside object) 54ms 57ms 63ms 228ms 416ms 8.6s
article (string inside array) 63ms 67ms 116ms 315ms 918ms 9.5s
recipe (name) 33ms 35ms 57ms 85ms 0ms 8.9s
recipe (description) 29ms 31ms 35ms 68ms 0ms 5.8s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 67ms 71ms 79ms 360ms 1478ms 14.5s
synthetic (string inside object) 66ms 69ms 74ms 637ms 1370ms 10.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 82ms 91ms 179ms 305ms 2919ms 17.1s
article (body) 17ms 22ms 38ms 255ms 588ms 6.2s
article (string inside object) 75ms 82ms 91ms 231ms 2552ms 11.5s
article (string inside array) 88ms 93ms 100ms 232ms 3166ms 12.4s
recipe (name) 50ms 52ms 71ms 109ms 1019ms 10.9s
recipe (description) 46ms 48ms 53ms 99ms 751ms 7.8s
recipe (instructions) 6ms 9ms 9ms 23ms 39ms 3.4s
synthetic (title) 176ms 191ms 314ms 618ms 11156ms 28.7s
synthetic (string inside object) 165ms 173ms 346ms 944ms 10074ms 22.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RitaDias RitaDias marked this pull request as ready for review November 13, 2024 13:41
@RitaDias RitaDias requested a review from a team as a code owner November 13, 2024 13:41
@RitaDias RitaDias requested review from juice49 and jordanl17 and removed request for a team and juice49 November 13, 2024 13:41
@RitaDias RitaDias changed the title fix(sanity): fix issue where the input change wasn't impacting the ca… feat(sanity): Add timezones to create release and to the release details Nov 13, 2024
@RitaDias RitaDias removed the request for review from jordanl17 November 13, 2024 13:42
@RitaDias RitaDias merged commit d46e8c9 into corel Nov 13, 2024
62 checks passed
@RitaDias RitaDias deleted the fix-calendar-input branch November 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant