test(sanity): ReleaseSummary tests #7870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Nov 25, 2024 8:36 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Mon, 25 Nov 2024 20:39:53 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
jordanl17
changed the title
jordanl17
changed the title
jordanl17
requested review from
rexxars
and removed request for
a team and
rexxars
RitaDias
commented
Nov 26, 2024
Comment on lines
+188
to
+189
| timeout: 5000, | ||
| interval: 500, |
There was a problem hiding this comment.
@jordanl17 seriously, was the issue the whole time just a timeout? 🥲
There was a problem hiding this comment.
Not quite - this seemed to be some flakiness in the tests, and I'm not quite sure why. Adding in a longer timeout seems to resolve the flake, but there were quite a few other parts necessary to actually get these tests to work:
- awaiting the
waitForfor the spinner to go away and the table to render - Updating the mock for
DefaultPreviewto pass the props through - Something else that I can't remember...
There was a problem hiding this comment.
God, this is so frustrating 😭 😂
RitaDias
changed the title
bjoerge
approved these changes
Nov 26, 2024
| useBundleDocumentsMockReturnWithResults, | ||
| } from './__mocks__/useBundleDocuments.mock' | ||
|
|
||
| vi.mock('../../../index', () => ({ |
There was a problem hiding this comment.
could we be more specific about the path here? I think it's preferable to mock the file where the function is defined, e..g where useDocumentPresence is actually defined. Same with useDocumentPreviewStore. That would ensure these gets mocked also in a (potential future case) where these are imported from a more specific internal path.
| }), | ||
| useDocumentPreviewStore: vi.fn().mockReturnValue({ | ||
| unstable_observeDocumentIdSet: vi.fn(() => ({ | ||
| pipe: vi.fn(), |
There was a problem hiding this comment.
Could the unstable_observeDocumentIdSet mock instead return an observable? It's not clear to me what mocking pipe() here does 🤔
| vi.mock('../../../../preview/components/_previewComponents', async () => { | ||
| return { | ||
| _previewComponents: { | ||
| default: vi.fn((arg) => <DefaultPreview {...arg} />), |
There was a problem hiding this comment.
Could this be a dummy component or are we asserting anything "default preview" specific?
There was a problem hiding this comment.
We are asserting on the passing through and rendering of the document preview itself. this mock only exists as the _previewComponents has an as yet unknown quirk that during test runs all the exports are set to undefined rather than their correct components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What to review
Testing
Notes for release